Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Optional final ; in field declarations of Structs and Messages #272

Closed
wants to merge 5 commits into from
Closed

feat: Optional final ; in field declarations of Structs and Messages #272

wants to merge 5 commits into from

Conversation

novusnota
Copy link
Member

Depends on #271
Towards #255

@novusnota novusnota marked this pull request as ready for review June 24, 2024 15:49
@novusnota novusnota mentioned this pull request Jun 24, 2024
Closed
14 tasks
@anton-trunov
Copy link
Member

Depends on #271

I don't see a real dependency here. Let's branch off of the main branch, otherwise it's hard to review PRs in isolation

@novusnota novusnota mentioned this pull request Jun 24, 2024
Closed
@novusnota
Copy link
Member Author

novusnota commented Jun 24, 2024 •
edited
Loading

Seems like I broke this and #271 pull requests. Will close those and re-create again, with suggestions applied — #273

@novusnota novusnota closed this Jun 24, 2024
@novusnota novusnota deleted the optional-semi-in-struct-and-message-decl branch June 24, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anton-trunov anton-trunov Awaiting requested review from anton-trunov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@novusnota @anton-trunov