icons-angular package

[BG-Software-BG]

No description provided.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
tabler-icons	✅ Ready (Inspect)	Visit Preview	Jul 23, 2024 5:53pm

[github-actions]

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days.

[meowzhin]

What can we do to kickstart this PR again? It would be great to have an official package for angular. Can I do something?

[github-actions]

✅ All icons are valid!

[github-actions]

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days.

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[the-ult]

What prevents this PR from being merged?
Is there anything with which we can help?

[github-actions]

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days.

[the-ult]

@codecalm or @BG-Software-BG what can we do to get this merged?

[BG-Software-BG]

@the-ult

It's not completely done yet. It needs some improvements and a test project, which is started but not finished..

I haven't had time to finish this package. I'll try to do this in the near future.
If you are able to work on test/test-angular project and give me some advices on potential improvements, I will be grateful.

[the-ult]

I will try to make some time this (or next week) to dive into your code and possible tests 👍🏼

Would it be an idea to use Angular 18 and use new features like:

• standalone
• signals (input/output/contentchild,etc)
• inject() vs constructor?

I could try to migrate the current code as well

[BG-Software-BG]

It's already prepared as standalone component.

We can use signals and inject(), but I think that's not the main priority. I want this package to be compatible with Angular 16+.

[the-ult]

Since v16 (LTS) ends one week before v19 (08-11-2024). I would suggest only supporting 17+

• https://angular.dev/reference/releases#actively-supported-versions

That way we can use signals etc without problems and we can create a more future proof package.

[BG-Software-BG]

Ok, that's a good point. You can change this package to use new features of Angular 17.

[the-ult]

I tried to add some changes to this PR. But had some trouble to get the angular-test running. (can't find the local library etc.. )

So for the time being, added a PR to the unofficial tabler-icons-angular to upgrade it to v18:

pierreavn/angular-tabler-icons#143