Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix X-Matrix auth parsing #617

Merged
merged 2 commits into from
Sep 4, 2024
Merged

Fix X-Matrix auth parsing #617

merged 2 commits into from
Sep 4, 2024

Conversation

turt2live
Copy link
Member

Fixes #609

@turt2live turt2live marked this pull request as ready for review September 4, 2024 22:25
@turt2live turt2live merged commit 7d4e9d5 into main Sep 4, 2024
3 of 4 checks passed
@turt2live turt2live deleted the travis/fix-xmatrix branch September 4, 2024 22:25
CobaltCause
CobaltCause reviewed Sep 8, 2024
View reviewed changes
util/http.go
isKey = false
continue

pairs := strings.Split(paramCsv, ",")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't this break if , appears inside a quoted value?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably, but also , is illegal inside a value, regardless of quotations.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(there's also no possible value which contains ,)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CobaltCause CobaltCause CobaltCause left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

X-Matrix auth handling requires '" illegally
2 participants
@turt2live @CobaltCause