Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support MSC3916 (without MSC3911) #509

Merged
merged 51 commits into from
Jul 3, 2024
Merged

Support MSC3916 (without MSC3911) #509

merged 51 commits into from
Jul 3, 2024

Conversation

turt2live
Copy link
Member

@turt2live turt2live commented Nov 25, 2023 •
edited
Loading

MSC3911 adds complexity that shouldn't block this feature.

See matrix-org/matrix-spec-proposals#3916
See #465
Closes #103
Closes #266
Closes #118

TODO:

  • MSC3916 - Split endpoints into Client-Server and Federation APIs
  • MSC3916 - X-Matrix authentication on Federation APIs
  • MSC3916 - Access token authentication on Client-Server APIs
  • MSC3916 - multipart/mixed Content-Type on new /download and /thumbnail endpoints
  • MSC3916 - Use new endpoints to download media
  • MSC3916 - Tests

@turt2live turt2live mentioned this pull request Nov 25, 2023
Merged
@turt2live turt2live force-pushed the travis/msc3916-only branch 6 times, most recently from 3d0ac66 to d78ec11 Compare December 1, 2023 03:40
@turt2live turt2live mentioned this pull request Feb 10, 2024
Draft
@turt2live turt2live force-pushed the travis/msc3916-only branch 6 times, most recently from b7f723f to c7a8d4f Compare February 20, 2024 23:02
@turt2live turt2live mentioned this pull request Apr 11, 2024
Merged
4 tasks
github-advanced-security[bot]
github-advanced-security bot found potential problems May 4, 2024
View reviewed changes
test/test_internals/util_client.go Dismissed Show dismissed Hide dismissed
@turt2live turt2live force-pushed the travis/msc3916-only branch 3 times, most recently from 5b49457 to 17a78d5 Compare May 25, 2024 00:33
@turt2live turt2live marked this pull request as ready for review May 29, 2024 23:30
github-advanced-security[bot]
github-advanced-security bot found potential problems Jun 20, 2024
View reviewed changes
matrix/server_discovery.go Fixed Show fixed Hide fixed
api/_routers/97-require-server-auth.go Fixed Show fixed Hide fixed
matrix/requests.go Fixed Show fixed Hide fixed
matrix/server_discovery.go Fixed Show fixed Hide fixed
@zecakeh zecakeh mentioned this pull request Jun 22, 2024
Merged
@turt2live
Ensure signing keys exist inside container
03dd83e
@turt2live
Fix signing key alignment between dependencies
9405db7
@turt2live
Ensure signing key information is carried into the config object
d2862d0
@turt2live
Generally treat homeserver config a bite more safely
5af3035
@turt2live
Support and use new 3916v2 federation download URL
4572673
@turt2live
Fix signing key permissions?
1cc666d
@turt2live
Fix routing
b0ba084
@turt2live
Update redirect-supporting behaviour
c7776f0
@turt2live
Support redirects
bf17b97
@turt2live
Finish tests
21e8281
@turt2live
Mark test function as deprecated to discourage use
99ab04a
@turt2live
Avoid testcontainers tests from overwriting the config concurrently.
8f01e45
@turt2live
host.docker.internal doesn't exist on linux
fa40656
@turt2live
Temporarily disable upload tests
5f16648
@turt2live
Support federation thumbnails again
806464d
@turt2live
Fix tests for auth header
5133471
@turt2live
Switch to stable endpoints
9697e11
@turt2live
Maybe use the correct stable endpoint too
85e7cbe
@turt2live
Revert "Temporarily disable upload tests"
69ac7b9 
This reverts commit e21fa01.
@turt2live turt2live mentioned this pull request Jul 2, 2024
Open
@turt2live
Copy link
Member Author

I'm giving up trying to fix the tests here: #589

@turt2live turt2live merged commit 1c834ea into main Jul 3, 2024
4 of 5 checks passed
@turt2live turt2live deleted the travis/msc3916-only branch July 3, 2024 22:23
@turt2live turt2live mentioned this pull request Jul 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement MSC1902 Sign remote media requests Start implementation for media repo auth (MSC701)
1 participant
@turt2live