Skip to content

Skip annotating invalid frames #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
eljamm wants to merge 1 commit into from
Closed

Skip annotating invalid frames #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 28 additions & 24 deletions lua/perfanno/callgraph.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,24 +65,26 @@ local function process_traces(traces)
for _, frame in ipairs(trace.frames) do
local symbol, file, linenr = frame_unpack(frame)

if not visited_lines[file .. ":" .. linenr] then
visited_lines[file .. ":" .. linenr] = true

util.init(node_info, file, {})
util.init(
node_info[file],
linenr,
{ count = 0, rec_count = 0, out_counts = {}, in_counts = {} }
)

node_info[file][linenr].count = node_info[file][linenr].count + trace.count
max_count = math.max(max_count, node_info[file][linenr].count)
end
if file and linenr then
if not visited_lines[file .. ":" .. linenr] then
visited_lines[file .. ":" .. linenr] = true

util.init(node_info, file, {})
util.init(
node_info[file],
linenr,
{ count = 0, rec_count = 0, out_counts = {}, in_counts = {} }
)

node_info[file][linenr].count = node_info[file][linenr].count + trace.count
max_count = math.max(max_count, node_info[file][linenr].count)
end

-- This counts how many times a line is called *including* recursive calls.
node_info[file][linenr].rec_count = node_info[file][linenr].rec_count + trace.count
-- This counts how many times a line is called *including* recursive calls.
node_info[file][linenr].rec_count = node_info[file][linenr].rec_count + trace.count
end

if symbol then
if file and symbol then
-- Symbol counts need to be done separately because of potential recursion.
if not visited_symbols[file .. ":" .. symbol] then
visited_symbols[file .. ":" .. symbol] = true
Expand All @@ -108,15 +110,17 @@ local function process_traces(traces)
local _, file1, linenr1 = frame_unpack(frame1)
local _, file2, linenr2 = frame_unpack(frame2)

util.init(node_info[file1][linenr1].out_counts, file2, {})
util.init(node_info[file1][linenr1].out_counts[file2], linenr2, 0)
node_info[file1][linenr1].out_counts[file2][linenr2] = node_info[file1][linenr1].out_counts[file2][linenr2]
+ trace.count
if file1 and linenr1 and file2 and linenr2 then
util.init(node_info[file1][linenr1].out_counts, file2, {})
util.init(node_info[file1][linenr1].out_counts[file2], linenr2, 0)
node_info[file1][linenr1].out_counts[file2][linenr2] = node_info[file1][linenr1].out_counts[file2][linenr2]
+ trace.count

util.init(node_info[file2][linenr2].in_counts, file1, {})
util.init(node_info[file2][linenr2].in_counts[file1], linenr1, 0)
node_info[file2][linenr2].in_counts[file1][linenr1] = node_info[file2][linenr2].in_counts[file1][linenr1]
+ trace.count
util.init(node_info[file2][linenr2].in_counts, file1, {})
util.init(node_info[file2][linenr2].in_counts[file1], linenr1, 0)
node_info[file2][linenr2].in_counts[file1][linenr1] = node_info[file2][linenr2].in_counts[file1][linenr1]
+ trace.count
end
end
end

Expand Down