Remove deprecated secure pair in favor of tls.connect #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 4, 2017 15:51
- SecurePair is deprecated and generates warnings when it's used - Refactor to use `tls.TLSSocket()` to secure existing socket - Do this inline instead of external `starttls` module - Add package.lock - Fix license regex warning
- You can pass an existing socket in the options of `tls.connect` and it will use that instead of creating a new one - `new tls.TLSSocket` doesn't fire the right events despite what the docs say (they know it's an issue) - Remove debug statements because I think I have it working
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes these deprecation warnings:
Some Notes:
tls.TLSSocket()tls.TLSSocket()doesn't seem to behave exactly as the docs say, it's an open issuetls.connect()can reuse a socketstarttlsor it's outdated dependencies