Update intro and add new reestablish tests to splicing-test.md#5
Update intro and add new reestablish tests to splicing-test.md#5t-bast merged 6 commits intot-bast:splicingfrom
Conversation
Addition to intro to make sure splice variations are also tested.
Three new tests that rift on the reconnection after sending tx_signatures and update_add_htlc .
|
The new tests may redundantly test existing non-splice reestablish behavior, but it's hard to know what side effects splice implementations may have on existing functionality. |
t-bast
left a comment
t-bast
left a comment
There was a problem hiding this comment.
Those tests look useful, but can you add a matching PR on eclair that verifies the values used in channel_reestablish in unit tests?
I created Eclair PR #3094 with new/modified tests used in the interop testing scripts. |
remyers
force-pushed
the
splicing-add-tests
branch
from
1319d59 to
0114973
Compare
bolt02/splicing-test.md
Outdated
| | | +------------+ +------------+ | ||
| ``` | ||
|
|
||
| ### Disconnection after exchanging `tx_signatures` and both sides send `commit_sig` for channel update; `revoke_and_ack` not received |
There was a problem hiding this comment.
It looks like this test case should appear before the previous one ("Disconnection after exchanging tx_signatures and both sides send commit_sig for channel update"), since it stops one step earlier in the protocol than the previous one?
There was a problem hiding this comment.
Fixed in 9dc1c78. The original order matched how I implemented them in the interop tests, but you're right swapping the order of he last two would be more logical.
I could also change the names so that the last test is "revoke_and_ack is received" and remove "revoke_and_ack is not received", but it would be kind of a hassle if I have to also update the interop tests to match the new names.
bolt02/splicing-test.md
Outdated
| * [Disconnection with concurrent `splice_locked`](#disconnection-with-concurrent-splice_locked) | ||
| * [Disconnection after exchanging `tx_signatures` and one side sends `commit_sig` for channel update](#disconnection-after-exchanging-tx_signatures-and-one-side-sends-commit_sig-for-channel-update) | ||
| * [Disconnection after exchanging `tx_signatures` and both sides send `commit_sig` for channel update](#disconnection-after-exchanging-tx_signatures-and-both-sides-send-commit_sig-for-channel-update) | ||
| * [Disconnection after exchanging `tx_signatures` and both sides send `commit_sig` for channel update; revoke_and_ack not received](#disconnection-after-exchanging-tx_signatures-and-both-sides-send-commit_sig-for-channel-update-revoke_and_ack-not-received) |
There was a problem hiding this comment.
nit:
| * [Disconnection after exchanging `tx_signatures` and both sides send `commit_sig` for channel update; revoke_and_ack not received](#disconnection-after-exchanging-tx_signatures-and-both-sides-send-commit_sig-for-channel-update-revoke_and_ack-not-received) | |
| * [Disconnection after exchanging `tx_signatures` and both sides send `commit_sig` for channel update; `revoke_and_ack` not received](#disconnection-after-exchanging-tx_signatures-and-both-sides-send-commit_sig-for-channel-update-revoke_and_ack-not-received) |
2 participants
These changes are the result of running interop tests with clightning. This PR suggests running variants of the happy path for splices and adds three new tests that rift on the reestablish tests.