bug: URL-encoded proxy username and password get passed to Basic auth

[barjin]

The URL.username and URL.password properties are URL encoded (not noticeable unless you try to pass special characters like % or $ in there). The proxy expects the Basic authentication header to contain an unencoded username and password (or the base64 representation of those).

To avoid problems with authentication containing special characters, we should call decodeURIComponent on both username and password before concating them and passing those to the base64 encoder here:

http2-wrapper/source/proxies/get-auth-headers.js

Lines 4 to 14 in f1a1776

	const {username, password} = self.proxyOptions.url;
	if (username || password) {
	const data = `${username}:${password}`;
	const authorization = `Basic ${Buffer.from(data).toString('base64')}`;
	return {
	'proxy-authorization': authorization,
	authorization
	};
	}

[barjin]

Ah, now I see - it's a duplicate of #104. For what it's worth, I still believe this is how the authentication should be handled, as any other client I tried does it this way (Chrome, Firefox, even curl).