Fix dynamic function return type extension for get_sites()
#155
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
get_sites()
,Type::getConstantScalarValues()
),instanceof
.What has been fixed?
$args['fields'] = 'count'
but$args['fields'] = 'ids'
and$args['count']
. The extension now checks for both$args['fields]
and$args['count']
. Not properly checking for 'count' led to incorrect return types for truthy count types.Todo: