Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix return type of the_title() and single_month_title() #145

Merged
merged 3 commits into from
Feb 8, 2023
Merged

Fix return type of the_title() and single_month_title() #145

merged 3 commits into from
Feb 8, 2023

Conversation

IanDelMar
Copy link
Contributor

This PR fixes the return types for the_title() and single_month_title() in EchoParameterDynamicFunctionReturnTypeExtension.

I forgot to add the other types in #111 and #143.

@IanDelMar @szepeviktor
remove superfluous white space
072568c 
Co-authored-by: Viktor Szépe <[email protected]>
@szepeviktor
Copy link
Owner

@johnbillion Do you have any comments?

johnbillion
johnbillion approved these changes Feb 8, 2023
View reviewed changes
Copy link
Contributor

@johnbillion johnbillion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catches.

@szepeviktor szepeviktor merged commit 927c0f1 into szepeviktor:master Feb 8, 2023
@IanDelMar IanDelMar deleted the fix-echo-param branch February 9, 2023 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnbillion johnbillion johnbillion approved these changes

@szepeviktor szepeviktor szepeviktor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IanDelMar @szepeviktor @johnbillion