Add AssertWpErrorTypeSpecifyingExtension / AssertNotWpErrorTypeSpecifyingExtension

[swissspidy]

Might need a bit of help with the implementation & tests, but I think this should cover the basics.

Fixes #30

[johnbillion]

This might be possible with the new docblock-based assertions instead: https://phpstan.org/blog/phpstan-1-9-0-with-phpdoc-asserts-list-type

[johnbillion]

Although that would mean bumping the minimum PHPStan requirement up to the latest.

[swissspidy]

@johnbillion That would mean having to add the docblocks in core, right?

[szepeviktor]

bumping the minimum PHPStan requirement up to the latest.

I'm not a maintainer.
I can write code only for myself.

[szepeviktor]

...okay let's release v1.2.0 after this PR

[johnbillion]

That would mean having to add the docblocks in core, right?

The https://github.com/php-stubs/wordpress-stubs/ library has a node visitor that allows additional tags to be added to the docblocks for function stubs, but AFAICT the methods in the test suite aren't generated as part of those stubs, so for now I think this type specifying extension makes the most sense actually 👍

[swissspidy]

Just marking as ready for review in the hopes of triggering tests to run... Can't get them to work locally somehow.

[szepeviktor]

CI does not start.
Let's see it on master! https://app.travis-ci.com/github/szepeviktor/phpstan-wordpress/builds/257654878

[szepeviktor]

@swissspidy There are 2 instances of

--- Expected
+++ Actual
@@ @@
-'WP_Error'
+'int|WP_Error'

[szepeviktor]

Importing WP_UnitTestCase_Base may be missing from tests.

[herndlm]

hey, I still have my phpstorm open from yesterday basically. I can quickly check if I see something :)

[swissspidy]

Oh, did not expect this to be merged 😅

There's probably something silly I missed with these extensions. Again, I haven't been able to run the tests locally for some reason, so it was just copy & paste

@herndlm Any help is much appreciated, thank you!

[herndlm]

Viktor's merge finger was too fast :)

[szepeviktor]

Viktor's merge finger was too fast :)

CI was not running in this PR

Please continue in a new PR fixing this one.

[herndlm]

I think I figured it out, I'll open a PR explaining it