Update Neutron ruleset (#25)

* Includes the NeutronStandard sniff wise
* Transforms exclusions to non-inclusions
* Replaces NeutronStandard.Functions.LongFunction with SlevomatCodingStandard.Functions.FunctionLength
* Replaces NeutronStandard.Whitespace.NewlineBetweenFunctions.MissingNewline with Squiz.WhiteSpace.FunctionSpacing

Update NeutronRuleset.xml

PSR12NeutronRuleset/NeutronRuleset.xml

@@ -1,9 +1,53 @@
 <?xml version="1.0"?>
 <ruleset name="NeutronRuleset">
     <description>Neutron Ruleset.</description>
+
     <rule ref="VariableAnalysis"/>
-    <rule ref="NeutronStandard"/>
+
+    <!-- VariableAnalysis - customization -->
+    <rule ref="VariableAnalysis.CodeAnalysis.VariableAnalysis.UndefinedVariable">
+        <type>error</type>
+    </rule>
+    <rule ref="VariableAnalysis.CodeAnalysis.VariableAnalysis">
+        <properties>
+            <property name="allowUnusedCaughtExceptions" value="true"/>
+        </properties>
+    </rule>
+
+    <!-- NeutronStandard - full set of rules -->
+    <!-- Covered by Generic.Arrays.DisallowLongArraySyntax
+    <rule ref="NeutronStandard.Arrays.DisallowLongformArray"/> -->
+    <rule ref="NeutronStandard.AssignAlign.DisallowAssignAlign"/>
+    <rule ref="NeutronStandard.Conditions.DisallowConditionAssignWithoutConditional"/>
+    <!-- Covered by forbidden functions rule
+    <rule ref="NeutronStandard.Constants.DisallowDefine"/>
+    <rule ref="NeutronStandard.Extract.DisallowExtract"/>  -->
+    <rule ref="NeutronStandard.Functions.DisallowCallUserFunc"/>
+    <!-- Covered by SlevomatCodingStandard.Functions.FunctionLength
+    <rule ref="NeutronStandard.Functions.LongFunction"/> -->
+    <rule ref="NeutronStandard.Functions.TypeHint"/>
+    <rule ref="NeutronStandard.Functions.VariableFunctions"/>
+    <rule ref="NeutronStandard.Globals.DisallowGlobalFunctions"/>
+    <rule ref="NeutronStandard.MagicMethods.DisallowMagicGet"/>
+    <rule ref="NeutronStandard.MagicMethods.DisallowMagicSerialize"/>
+    <rule ref="NeutronStandard.MagicMethods.DisallowMagicSet"/>
+    <rule ref="NeutronStandard.MagicMethods.RiskyMagicMethod"/>
+    <!-- Covered by Slevomat
+    <rule ref="NeutronStandard.StrictTypes.RequireStrictTypes"/> -->
+    <rule ref="NeutronStandard.Whitespace.DisallowMultipleNewlines"/>
+    <!-- Covered by Squiz.WhiteSpace.FunctionSpacing
+    <rule ref="NeutronStandard.Whitespace.NewlineBetweenFunctions.MissingNewline"/> -->
+    <!-- We use a differen spacing rule
+    <rule ref="NeutronStandard.Whitespace.RequireParenthesisSpacing"/> -->
+
+    <!-- NeutronStandard - customization -->
+    <rule ref="NeutronStandard.Functions.TypeHint.NoArgumentType">
+        <severity>0</severity>
+    </rule>
+
     <rule ref="WordPress-Core"/>
+
+    <!-- WordPress-Core - customization -->
     <rule ref="Squiz.Commenting">
         <severity>0</severity>
     </rule>
@@ -40,29 +84,15 @@
     <rule ref="WordPress.WhiteSpace.ControlStructureSpacing.NoSpaceAfterCloseParenthesis">
         <severity>0</severity>
     </rule>
-    <rule ref="NeutronStandard.StrictTypes.RequireStrictTypes.StrictTypes">
-        <type>warning</type>
-    </rule>
     <rule ref="WordPress.Arrays.ArrayDeclarationSpacing.AssociativeArrayFound">
         <type>warning</type>
     </rule>
     <rule ref="WordPress.DB.DirectDatabaseQuery.NoCaching">
         <severity>0</severity>
     </rule>
-    <rule ref="VariableAnalysis.CodeAnalysis.VariableAnalysis.UndefinedVariable">
-        <type>error</type>
-    </rule>
-    <rule ref="VariableAnalysis.CodeAnalysis.VariableAnalysis">
-        <properties>
-            <property name="allowUnusedCaughtExceptions" value="true"/>
-        </properties>
-    </rule>
     <rule ref="WordPress.PHP.StrictInArray.MissingTrueStrict">
         <type>error</type>
     </rule>
-    <rule ref="NeutronStandard.Functions.TypeHint.NoArgumentType">
-        <severity>0</severity>
-    </rule>
     <rule ref="WordPress.DB.DirectDatabaseQuery.DirectQuery">
         <severity>0</severity>
     </rule>

PSR12NeutronRuleset/ruleset.xml

@@ -136,12 +136,7 @@
 
         <exclude name="Squiz.Operators.IncrementDecrementUsage"/>
 
-        <exclude name="NeutronStandard.Whitespace.RequireParenthesisSpacing"/>
-        <exclude name="NeutronStandard.Constants.DisallowDefine"/>
-        <exclude name="NeutronStandard.StrictTypes.RequireStrictTypes"/>
-
         <!-- Covered by forbidden functions rule -->
-        <exclude name="NeutronStandard.Extract.DisallowExtract"/>
         <exclude name="WordPress.PHP.DontExtract"/>
 
         <exclude name="VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariable"/>
@@ -167,6 +162,12 @@
 
     <rule ref="WordPress-Extra"/>
 
+    <rule ref="Squiz.WhiteSpace.FunctionSpacing">
+        <properties>
+            <property name="spacing" value="1"/>
+        </properties>
+    </rule>
+
     <!-- TODO
     Look-and-See: https://github.com/squizlabs/PHP_CodeSniffer/tree/master/src/Standards/Squiz/Sniffs/PHP
     -->
@@ -232,6 +233,14 @@
     <rule ref="SlevomatCodingStandard.ControlStructures.RequireTernaryOperator"/>
     <rule ref="SlevomatCodingStandard.ControlStructures.DisallowYodaComparison"/>
     <rule ref="SlevomatCodingStandard.Functions.DisallowArrowFunction"/>
+    <rule ref="SlevomatCodingStandard.Functions.FunctionLength">
+        <properties>
+            <property name="maxLinesLength" value="40"/>
+            <property name="includeComments" value="false"/>
+            <property name="includeWhitespace" value="false"/>
+        </properties>
+        <type>warning</type>
+    </rule>
     <rule ref="SlevomatCodingStandard.TypeHints.DisallowArrayTypeHintSyntax"/>
     <rule ref="SlevomatCodingStandard.TypeHints.LongTypeHints"/>
     <rule ref="SlevomatCodingStandard.TypeHints.NullTypeHintOnLastPosition"/>