-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new: Implemented GitHub actions CI #174
base: master
Are you sure you want to change the base?
Conversation
Nice! I'm not familiar with Github Actions yet so it might take me a bit to learn Github Actions, and follow through and review this properly, but it looks good so far. For the Prettier options, whatever runs and keeps the code the same without needing formatting commits works for me for now. As for How does that sound? |
Ok, I'll fix that and open up a PR pointing to upstream, then, incorporate changes in this PR's branch.
That sounds good, I don't know Perl, so I'll be glad if you can fix this on your master branch, then I can merge it to this pull request and implement caching of the file downloaded to this workflow. |
Yeah I update the Perl script for sure, maybe sometime this week |
@PolpOnline Sorry for the delay. I added a |
(Can we pretend it didn't happen?)
For some reason, the cache key doesn't have the hash of the files in there. However, this shouldn't be a problem anyway because the hashes of the files are checked by the Perl script. |
Hi, I just implemented the GitHub actions CI to this repo.
IMO, that's better than Travis CI because its better integration with GitHub.
Now, there are two main problems with this pull request:
yarn format
on my ArchLinux machine and it gives me the same errors that the CI is giving. Maybe tweaking a bit with the.prettierrc
configuration file can fix the issue.update_exiftool.pl
doesn't check if the version installed of ExifTool is the latest, so every time the CI runs it has to download it from the exiftool.org site, I think that this is a useless bandwidth waste. My proposal to resolve this issue would be inserting some kind of check in the Perl script to test if the version downloaded is the latest and then cache the ExifTool files to reuse between one CI run and another (I already know how to implement the latter).Maybe I could try to implement a solution in the CI workflow but that would be more complicated than what I proposed (and also won't work if the runner isn't the CI).
Sorry for my bad English.
EDIT: nvm, I found what the first issue problem is, it's just that you used 4 spaces instead of a tab to format files, this is by default wrong for Prettier, just changing the
.prettierrc
file should be sufficient to tell Prettier not to substitute spaces with tabs. Can you tell me which indentation format do you prefer?