Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP 通知元を含めるように #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

WIP 通知元を含めるように #6

wants to merge 1 commit into from

Conversation

syusui-s
Copy link
Owner

@syusui-s syusui-s commented Jun 2, 2018 •
edited
Loading

Fix #7

@syusui-s syusui-s self-assigned this Jun 2, 2018
syusui-s
syusui-s commented Jun 4, 2018
View reviewed changes
YouTubeCommentNotifier.user.js Outdated

if (notificationService.notSupported()) {
window.console.error('Notification がサポートされていません');
window.alert('ブラウザが通知機能にされていません');
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

が搭載されていません

YouTubeCommentNotifier.user.js Outdated
*/
constructor(title, iconUrl, body) {
Object.assign(this, { title, iconUrl, body });
constructor(title, iconUrl, body, source) {
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ソースの部分をどう提示するかはファクトリに任せたい

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@syusui-s syusui-s

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@syusui-s