Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement poll function and add feature to generate random based on cpu instruction. #4

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Implement poll function and add feature to generate random based on cpu instruction. #4

merged 1 commit into from
Sep 19, 2023

Conversation

ken4647
Copy link
Contributor

@ken4647 ken4647 commented Sep 13, 2023 •
edited
Loading

  1. Implement poll function.
  2. Add random-hw feature to generate random based on cpu instruction.
  3. modify feature.txt in Redis and excepted output file in parallel testcase.

@ken4647 ken4647 changed the title Dev Implement poll function and add feature to generate random based on cpu instruction. Sep 13, 2023
coolyjg
coolyjg reviewed Sep 14, 2023
View reviewed changes
Copy link
Contributor

@coolyjg coolyjg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix warnings generated by clippy.
Think of a way to handle warnings for riscv in rand.rs: 89

apps/c/redis/features.txt Show resolved Hide resolved
ulib/axlibc/src/rand.rs Outdated Show resolved Hide resolved
ulib/axlibc/src/rand.rs Outdated Show resolved Hide resolved
coolyjg
coolyjg reviewed Sep 15, 2023
View reviewed changes
Copy link
Contributor

@coolyjg coolyjg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add doc about new features.
And I have to admit that I'm not so familiar with poll implementation.

ulib/axlibc/src/lib.rs Outdated Show resolved Hide resolved
@coolyjg
Copy link
Contributor

coolyjg commented Sep 18, 2023

Try to rebase all commits into one, and I think it's ok to merge.

@coolyjg coolyjg merged commit c18b02c into syswonder:dev Sep 19, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coolyjg coolyjg coolyjg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
I: RuxOS Initialization, Module Expan...
Development

Successfully merging this pull request may close these issues.
2 participants
@ken4647 @coolyjg