This repository was archived by the owner on Feb 6, 2026. It is now read-only.
Conversation
Signed-off-by: Fletcher Nichol <fletcher@systeminit.com>
Pin Deno to version 2.2.12 as this is the last version that successfully built via Hydra. All newer versions revert to source-building which takes way too long for every developer. References: NixOS/nixpkgs#417331 References: NixOS/nixpkgs#384838 Signed-off-by: Fletcher Nichol <fletcher@systeminit.com>
• Updated input 'nixpkgs':
'github:NixOS/nixpkgs/b1bebd0fe266bbd1820019612ead889e96a8fa2d' (2025-05-15)
→ 'github:NixOS/nixpkgs/fa64ec5c1ca6f17746f3defedb988b9248e97616' (2025-07-16)
• Updated input 'rust-overlay':
'github:oxalica/rust-overlay/58160be7abad81f6f8cb53120d5b88c16e01c06d' (2025-05-14)
→ 'github:oxalica/rust-overlay/dc221f842e9ddc8c0416beae8d77f2ea356b91ae' (2025-07-17)
Notable software updates:
```
❯ for cmd in buck2 deno node pnpm reindeer rustc tilt; do
command -v "$cmd" \
| sed -e 's#^/nix/store/[[:alnum:]]\{1,\}-##' -e 's#/bin/.\{1,\}$##'
done
buck2-unstable-2025-05-06
deno-2.2.12
nodejs-20.19.3
pnpm-10.12.4
reindeer-2025.07.14.00
rust-minimal-1.88.0
tilt-0.35.0
```
Signed-off-by: Fletcher Nichol <fletcher@systeminit.com>
See: <https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args> Signed-off-by: Fletcher Nichol <fletcher@systeminit.com>
See: <https://rust-lang.github.io/rust-clippy/master/index.html#obfuscated_if_else> Signed-off-by: Fletcher Nichol <fletcher@systeminit.com>
See: <https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return> Signed-off-by: Fletcher Nichol <fletcher@systeminit.com>
It's the Box-pocalypse! As taken from the Clippy docs: > A Result is at least as large as the Err-variant. While we expect that > variant to be seldom used, the compiler needs to reserve and move that > much memory every single time. Furthermore, errors are often simply > passed up the call-stack, making use of the ?-operator and its > type-conversion mechanics. If the Err-variant further up the call-stack > stores the Err-variant in question (as library code often does), it > itself needs to be at least as large, propagating the problem. See: <https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err> Signed-off-by: Fletcher Nichol <fletcher@systeminit.com>
Signed-off-by: Fletcher Nichol <fletcher@systeminit.com>
Signed-off-by: Fletcher Nichol <fletcher@systeminit.com>
Signed-off-by: Fletcher Nichol <fletcher@systeminit.com>
See: <https://rust-lang.github.io/rust-clippy/master/index.html#manual_contains> Signed-off-by: Fletcher Nichol <fletcher@systeminit.com>
github-actions
bot
added
A-sdf
Dependency Review✅ No vulnerabilities or OpenSSF Scorecard issues found.Scanned FilesNone |
|
Contributor
Author
|
/try |
|
Okay, starting a try! I'll update this comment once it's running...\n |
britmyerss
approved these changes
Jul 21, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A lot of updates, refactorings, changes, among the notables:
chore(deps): pin Deno to 2.2.12 until Hydra has newer pkg builds
Pin Deno to version 2.2.12 as this is the last version that successfully
built via Hydra. All newer versions revert to source-building which
takes way too long for every developer.
References: NixOS/nixpkgs#417331
References: NixOS/nixpkgs#384838
build(deps): update Nix dependencies (2025-W29)
• Updated input 'nixpkgs':
'github:NixOS/nixpkgs/b1bebd0fe266bbd1820019612ead889e96a8fa2d' (2025-05-15)
→ 'github:NixOS/nixpkgs/fa64ec5c1ca6f17746f3defedb988b9248e97616' (2025-07-16)
• Updated input 'rust-overlay':
'github:oxalica/rust-overlay/58160be7abad81f6f8cb53120d5b88c16e01c06d' (2025-05-14)
→ 'github:oxalica/rust-overlay/dc221f842e9ddc8c0416beae8d77f2ea356b91ae' (2025-07-17)
Notable software updates:
style(lint): inline variables into format strings
See: https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
chore: box many nested errors to reduce their overall sizes
It's the Box-pocalypse!
As taken from the Clippy docs:
See: https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err