make_image: log systemd-repart *.conf files at the --debug level

[marc-hb]

As discussed in #3948, systemd-repart *.conf files have default values which is convenient until this fails with some dreaded "disk full" error - then it becomes very mysterious. To considerably speed up the investigation about what exactly is full, show the configuration files in use when using --debug.

[marc-hb]

1 random QEMU timeout just like in unrelated #3992 .

It seems ToolsTreeDistribution is Fedora in most timeouts.

https://github.com/systemd/mkosi/actions/runs/19250690460/job/55034934798#step:11:5849

Now 2 timeouts after re-run:
https://github.com/systemd/mkosi/actions/runs/19252159958/job/55039247078?pr=3993
https://github.com/systemd/mkosi/actions/runs/19252159958/job/55039247127?pr=3993

Now just 1:
https://github.com/systemd/mkosi/actions/runs/19253565585/job/55043403913?pr=3993

Still not winning the lottery:
https://github.com/systemd/mkosi/actions/runs/19255156663/job/55048285518?pr=3993

1 failing again:
https://github.com/systemd/mkosi/actions/runs/19259212198/job/55060033981?pr=3993

Finally all green!
https://github.com/systemd/mkosi/actions/runs/19269008595

[behrmann]

Suggested change

	lines = 0
	for line in f:
	logging.debug(line.strip())
	lines += 1
	for lines, line in enumerate(f):
	logging.debug(line.strip())

though lines is then no longer a good name.

[behrmann]

Also, you could write something like truncated to X lines in the message above saying from which file this is and instead of enumerating lines do

for line in itertools.islice(f, 100):

[marc-hb]

Done.

---

As usual, QEMU from the Fedora ToolsTreeDistribution is hanging in 2 places.
https://github.com/systemd/mkosi/actions/runs/19315730637/job/55247012466?pr=3993

Last time I force-pushed and banged until they all passed but this is getting tedious :-(

[behrmann]

Last time I force-pushed and banged until they all passed but this is getting tedious :-(

You really don't need to. Sometimes CI is flaky, e.g. due to distro-specific problems, and in a lot of cases it is clear that the CI failure is not related to the change in the PR.

[behrmann]

That seems a bit arbitrary. Is the idea for it to be much longer than than all possible repart files? The number of directives for these files is about 40.

[marc-hb]

It is arbitrary. Yes, the idea is for this to be longer than all "regular" repart files, as a safety to protect the debug logs and keep them usable, triggered only when something went terribly wrong. For instance: a wrong .conf file landing there by accident. Or some other bug. I can summarize this as a one-line comment in the source.

The number of directives for these files is about 40.

I don't get this sorry. Did you mean 40 lines? Is this an average?

[behrmann]

I don't get this sorry. Did you mean 40 lines? Is this an average?

That's just the rough amount of different directives for repart files. Even if you put multiple partitions in a file, which I've not seen done, to be honest, some of these directives are exclusive or dependent on others, so in general these files will be below 10 lines long.

[marc-hb]

Sample output:

=== /tmp/rq_mkosi_wspaces/mkosi-workspace-nkv888ul/repart-definitions/10-root.conf ===
‣ [Partition]
‣ Type=root
‣ Format=btrfs
‣ CopyFiles=/
‣ Minimize=guess
‣ 
 === /tmp/rq_mkosi_wspaces/mkosi-workspace-nkv888ul/repart-definitions/00-esp.conf ===
‣ [Partition]
‣ Type=esp
‣ Format=vfat
‣ CopyFiles=/boot:/
‣ CopyFiles=/efi:/
‣ === 00-esp.conf truncated to 5 lines ===  (after changing the constant in the script)

[behrmann]

Let's shorten this somewhat, the truncation will never really be a thing

Suggested change

	logging.debug(f"\n === {c} ===")
	with open(c) as f:
	# Do not spam the logs in case something goes wrong
	maxlines = 100
	for line in itertools.islice(f, maxlines):
	logging.debug(line.strip())
	for anything_left in f:
	logging.debug(f"=== {c.name} truncated to {maxlines} lines ===")
	break
	logging.debug(f"# {c} (truncated to 100 lines)")
	with open(c) as f:
	for line in itertools.islice(f, 100):
	logging.debug(line.strip())

Using a # as the separator, makes these files still valid, when copied from screen.

[marc-hb]

Done.