Skip to content

run.py: always log the sandbox when a command fails #3992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
marc-hb wants to merge 2 commits into from
Closed

run.py: always log the sandbox when a command fails #3992

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a6afa5c
run.py: always log the sandbox when a command fails
marc-hb Nov 10, 2025
c2aab71
run.py: ruff format
marc-hb Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions mkosi/run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,10 +125,7 @@ def log_process_failure(sandbox: Sequence[str], cmdline: Sequence[str], returnco
else:
logging.error(f"{cmdline[0]} not found.")
else:
logging.error(
f'"{shlex.join([*sandbox, *cmdline] if ARG_DEBUG.get() else cmdline)}"'
f" returned non-zero exit code {returncode}."
)
logging.error(f'"{shlex.join([*sandbox, *cmdline])}" returned non-zero exit code {returncode}.')


def run(
Expand Down