Skip to content

Conversation

@jaymz82
Copy link
Collaborator

@jaymz82 jaymz82 commented Jun 6, 2025

PR Details

I have changed the way to calculate the minimum zoom we need to adjust the image to the viewport.

Description

Previously, the minimum was calculated in absolute terms. Currently, the minimum is calculated in relative terms, so we adjust the image size in this way.

Related Issue

#875

Motivation and Context

In case of large images, they were adjusted (zoom out) to fit the Window. Now it's not doing this properly, and even using the upper right slider (that controls the zoom), there is no way to see the whole image.

How Has This Been Tested

I have tested in local, using the show-case, with different images, and in Laboratory application of Modulab, in Atlas section.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • [ x] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • [x ] I have read the CONTRIBUTING document
  • [ x] My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly (README.md for each UI component)
  • I have added tests to cover my changes (at least 1 spec for each UI component with the same coverage as the master branch)
  • [ x] All new and existing tests passed
  • A new branch needs to be created from master to evolve previous versions
  • [ x] Increase version in package.json following Semantic Versioning
  • All UI components must be added into the showcase (at least 1 component with the default settings)
  • Add the issue into the right project with the proper status (In progress)

@codecov
Copy link

codecov bot commented Jun 6, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 58.04%. Comparing base (1ceee96) to head (6b7cc5f).

Files with missing lines Patch % Lines
...nts/src/lib/image-viewer/image-viewer.component.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           17.4.x     #999      +/-   ##
==========================================
+ Coverage   58.00%   58.04%   +0.03%     
==========================================
  Files         135      135              
  Lines        3805     3799       -6     
  Branches      676      673       -3     
==========================================
- Hits         2207     2205       -2     
+ Misses       1483     1478       -5     
- Partials      115      116       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@tlainez tlainez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Albert!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants