Skip to content

Conversation

@jferrer1W
Copy link
Contributor

PR Details

Fix Two list element counter when user filter results of left list thie counter must to show the elements filtered and by click the add all button the filtered left elements must to be added to the right list and not all.

Description

Fix the counters of Two element list, when user filter the list the counter should be to show only filtered elements, also, if the user click on add all button the filtered elements must to be added to the right list and not all as till now.

Related Issue

#877

Motivation and Context

How Has This Been Tested

Unit test

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the CONTRIBUTING document
  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly (README.md for each UI component)
  • I have added tests to cover my changes (at least 1 spec for each UI component with the same coverage as the master branch)
  • All new and existing tests passed
  • A new branch needs to be created from master to evolve previous versions
  • Increase version in package.json following Semantic Versioning
  • All UI components must be added into the showcase (at least 1 component with the default settings)
  • Add the issue into the right project with the proper status (In progress)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Two-list "Add all" and "Remove all" counters not consistent with the number of actually listed items when filtered

3 participants