Skip to content

Conversation

@jferrer1W
Copy link
Contributor

PR Details

Remove ensureIndex method in onModelChange event.

Description

I remove the ensureIndexVisible method from the OnModelChange event because it causes the scroll to return to the selected element every time this event is triggered. This means that if we have the first element selected and scroll down, when changing pages and OnModelChange is triggered, the scroll automatically returns to the first element.

Related Issue

#972

Motivation and Context

avoid the issue 972

Checklist

  • I have read the CONTRIBUTING document
  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly (README.md for each UI component)
  • I have added tests to cover my changes (at least 1 spec for each UI component with the same coverage as the master branch)
  • All new and existing tests passed
  • A new branch needs to be created from master to evolve previous versions
  • Increase version in package.json following Semantic Versioning
  • All UI components must be added into the showcase (at least 1 component with the default settings)
  • Add the issue into the right project with the proper status (In progress)

@codecov
Copy link

codecov bot commented Mar 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.74%. Comparing base (5f675f2) to head (5523efd).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #974      +/-   ##
==========================================
- Coverage   57.86%   57.74%   -0.12%     
==========================================
  Files         132      132              
  Lines        3743     3742       -1     
  Branches      659      659              
==========================================
- Hits         2166     2161       -5     
- Misses       1467     1470       +3     
- Partials      110      111       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The scroll does not work in the searchers once an item has been selected

4 participants