add Accordion component #950
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #950 +/- ##
==========================================
- Coverage 58.03% 57.84% -0.20%
==========================================
Files 132 133 +1
Lines 3744 3755 +11
Branches 659 660 +1
==========================================
- Hits 2173 2172 -1
- Misses 1460 1473 +13
+ Partials 111 110 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
carlosra85
requested changes
Nov 14, 2024
| @@ -0,0 +1,10 @@ | |||
| <div class="slab-flex-1 d-flex flex-column"> | |||
| <div class="mlab-accordion-header d-flex align-items-center font-weight-bold px-3" [ngStyle]="{'backgroundColor': headerColor}" (click)="isCollapsed = !isCollapsed"> | |||
Collaborator
There was a problem hiding this comment.
change mlab- for slab- or no prefix better
Collaborator
There was a problem hiding this comment.
Add also to documentation please.
Good job, thanks for the contrib!
carlosra85
previously approved these changes
Nov 14, 2024
carlosra85
previously approved these changes
Nov 20, 2024
jferrer1W
force-pushed
the
949-new-accordion-component
branch
from
9fb8d9e to
acbcdf4
Compare
carlosra85
previously approved these changes
Nov 21, 2024
vvinuelas
previously approved these changes
Jan 29, 2025
vinyulis
previously approved these changes
Feb 26, 2025
jferrer1W
dismissed stale reviews from vinyulis, vvinuelas, and carlosra85
via
9c06a92
carlosra85
approved these changes
Jun 3, 2025
vvinuelas
reviewed
Jun 4, 2025
| }) | ||
| export class ShowcaseAccordion { | ||
| constructor() { | ||
| } |
Contributor
There was a problem hiding this comment.
Empty constructor. Unnecessary?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
It contains the code to new Accordion component
Description
We have created a new Accordion component.
Related Issue
#949
Motivation and Context
Add generic component that now was into modulab
Types of changes
Checklist