Skip to content

Avoid An empty menu (box) remains visible when opening a three dots menu in one row in a grid without items #1006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Avoid An empty menu (box) remains visible when opening a three dots menu in one row in a grid without items #1006

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ad1eb3f
fix context menu grid dots without elements
jferrer1W Jun 2, 2025
c9e9145
add test
jferrer1W Jun 10, 2025
3ed6a98
update version fro 18.1.0 to 18.1.1
jferrer1W Jun 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion projects/systelab-components/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "systelab-components",
"version": "18.1.0",
"version": "18.1.1",
"license": "MIT",
"keywords": [
"Angular",
Expand Down
8 changes: 8 additions & 0 deletions ...lab-components/src/lib/grid/contextmenu/grid-context-menu-cell-renderer.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ import { SystelabPreferencesModule } from "systelab-preferences";
import { SystelabTranslateModule } from "systelab-translate";
import { Component } from "@angular/core";
import { AbstractGrid } from "systelab-components";
import { GridContextMenuComponent } from './grid-context-menu-component';
import createSpyObj = jasmine.createSpyObj;


interface TestData {
Expand Down Expand Up @@ -48,6 +50,7 @@ describe('GridContextMenuCellRendererComponent', () => {
const containerMock = {
removeSelectionOnOpenContextMenu: false,
getSelectedRows: () => [{id: 16, row: 0}],
popupmenu: createSpyObj('popupmenu', ['closeDropDown']),
dotsClicked: (rowIndex, selectedRows, event) => {
},
gridOptions: {
Expand Down Expand Up @@ -139,6 +142,11 @@ describe('GridContextMenuCellRendererComponent', () => {
expect(containerMock.gridOptions.api.deselectAll).toHaveBeenCalled()

})
it('Should to call closeDropDown of container when dotsClicked is called', () => {
component.agInit(paramsMock);
component.dotsClicked(eventMock);
expect((component['container'] as any).popupmenu.closeDropDown).toHaveBeenCalled();
});
})

describe('refresh', () => {
Expand Down
2 changes: 1 addition & 1 deletion ...systelab-components/src/lib/grid/contextmenu/grid-context-menu-cell-renderer.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export class GridContextMenuCellRendererComponent<T> implements AgRendererCompon

public dotsClicked(event: MouseEvent): void {
let selectedRows: T | Array<T> = this.data;

this.container?.popupmenu?.closeDropDown();
if (event.ctrlKey && !this.container.removeSelectionOnOpenContextMenu) {
selectedRows = this.container.getSelectedRows();
} else if (this.container.removeSelectionOnOpenContextMenu) {
Expand Down