Add Xiaomi Zero Fog Humidifier (shuii.humidifier.jsq001) support (#52)#55
Add Xiaomi Zero Fog Humidifier (shuii.humidifier.jsq001) support (#52)#55syssi merged 7 commits intosyssi:developfrom
Conversation
|
My changes already available in |
|
@syssi Hi, I'd like to get some feedback on PR and what steps are required to merge it and included into next release. Could you take a look on it? |
|
Slightly updated version send as PR to HA directly (home-assistant/core#33736). |
|
Thanks for your PR! Sorry for the late feedback. I wasn't aware of your PR right now. I will provide a code review asap! |
|
@syssi I've sent a rather refactored version of this PR to home-assistant/core#33736 but they want somebody to re-implement everything and do not use 'fan' platform for humidifiers any more. At the moment I'm just using my fork of your project to have a working HACS component for this device. |
|
I would like to merge your feature here for the meantime. Could you fix the conflict? |
|
Please wait a bit with merging this, I'd like to compare this version with my fork and HA pull request, probably this version is a bit out of date. I'll have some time to do it at the weekend. |
|
Alright! I marked your pull request as draft now. Just click "ready for review" if you're done. |
|
Ping! :-) |
|
Hi, I was on vacation recently, I'll take a look at this at the end of the month. |
| def led_brightness(self): | ||
| """Return the current brightness.""" | ||
| if self._state: | ||
| return AirhumidifierJsqLedBrightness(self._state_attrs[ATTR_LED_BRIGHTNESS]).name |
There was a problem hiding this comment.
Black would make changes.
line too long (93 > 79 characters)
undefined name 'AirhumidifierJsqLedBrightness'
3 participants
Xiaomi Zero Fog Humidifier (shuii.humidifier.jsq001) support (#52).
This pull request depends on my changes to
python-miiolibrary (see rytilahti/python-miio#642) which will be available in the next library update