Consolidate helper functions for pretty messages #565
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Review Agent Run #599c13Actionable Suggestions - 2
Additional Suggestions - 1
Review Details
AI Code Review powered by |
Changelist by BitoThis pull request implements the following key changes.
|
![bito-code-review[bot]](https://avatars.githubusercontent.com/in/1061978?s=60&v=4){kind=small}
jserv
force-pushed
the
pretty-messages
branch
from
099d3ba to
f7d56c4
Compare
Code Review Agent Run #67cd2cActionable Suggestions - 0Review Details
AI Code Review powered by |
jserv
force-pushed
the
pretty-messages
branch
from
f7d56c4 to
26eb7d2
Compare
This commit provides variants of 'notice' function: - notice(x) : colored as green - warn(x) : colored as yellow The suffix 'x' indicates the use as function calls in Makefile.
jserv
force-pushed
the
pretty-messages
branch
from
26eb7d2 to
89e89df
Compare
Code Review Agent Run #69f450Actionable Suggestions - 0Additional Suggestions - 1
Review Details
AI Code Review powered by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit provides variants of 'notice' function:
The suffix 'x' indicates the use as function calls in Makefile.
Summary by Bito
This PR implements a unified message formatting system for build output, introducing color-coded helper functions for standardized notice and warning messages. The changes consolidate multiple printf statements into consistent notice and warning functions, with support for both regular and shell-specific variants. The implementation uses green coloring for notices and yellow for warnings, improving build output readability.Unit tests added: False
Estimated effort to review (1-5, lower is better): 2