Skip to content

Use upstream SoftFloat and unify build system #557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 12, 2025
Merged

Use upstream SoftFloat and unify build system #557

merged 1 commit into from
Feb 12, 2025

Conversation

@jserv
Copy link
Contributor

@jserv jserv commented Feb 7, 2025 •
edited by bito-code-review bot
Loading

Replace custom Berkeley SoftFloat 3 package in 'src/softfloat' with the upstream one. It streamlines build system onfiguration for consistency.

Summary by Bito

Modernization of SoftFloat integration by migrating to upstream Berkeley SoftFloat-3 repository. Implementation includes updated submodule references, new dedicated mk/softfloat.mk file with comprehensive build configurations, and improved header inclusion paths. Build system modularity enhanced through separation of SoftFloat-specific rules and improved toolchain definitions.

Unit tests added: False

Estimated effort to review (1-5, lower is better): 2

@bito-code-review
Copy link

bito-code-review bot commented Feb 7, 2025 •
edited
Loading

Code Review Agent Run #ba12d7

Actionable Suggestions - 1
  • Makefile - 1
    • Consider adding softfloat.mk existence check · Line 117-120
Review Details
  • Files reviewed - 7 · Commit Range: a78b90b..a78b90b
    • .gitmodules
    • Makefile
    • mk/softfloat.mk
    • mk/toolchain.mk
    • src/emulate.c
    • src/riscv.h
    • src/softfloat
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful
    • Fb Infer (Static Code Analysis) - ✖︎ Failed

AI Code Review powered by Bito Logo

@bito-code-review
Copy link

bito-code-review bot commented Feb 7, 2025 •
edited
Loading

Changelist by Bito

This pull request implements the following key changes.

Key Change Files Impacted
Feature Improvement - SoftFloat Integration Modernization

- .gitmodules - Updated SoftFloat repository URL to use upstream Berkeley SoftFloat-3

- Makefile - Refactored SoftFloat build configuration and cleanup rules

- softfloat.mk - Added new build system file with comprehensive SoftFloat compilation rules

- toolchain.mk - Added AR utility definition for toolchain consistency

- emulate.c - Updated SoftFloat header inclusion path

- riscv.h - Updated SoftFloat header path to use upstream source

- softfloat - Updated submodule commit to use upstream version

bito-code-review[bot]
bito-code-review bot reviewed Feb 7, 2025
View reviewed changes
jserv
jserv commented Feb 7, 2025
View reviewed changes
Copy link
Contributor Author

@jserv jserv left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmarks

Benchmark suite Current: edfa83e Previous: 1b8f4b0 Ratio
Dhrystone 1316 Average DMIPS over 10 runs 1337 Average DMIPS over 10 runs 1.02
Coremark 939.158 Average iterations/sec over 10 runs 939.479 Average iterations/sec over 10 runs 1.00

This comment was automatically generated by workflow using github-action-benchmark.

@jserv jserv force-pushed the modular-softfloat branch from a78b90b to 2b375ea Compare February 7, 2025 18:44
@bito-code-review
Copy link

bito-code-review bot commented Feb 7, 2025 •
edited
Loading

Code Review Agent Run #e1b2a2

Actionable Suggestions - 0
Review Details
  • Files reviewed - 7 · Commit Range: 2b375ea..2b375ea
    • .gitmodules
    • Makefile
    • mk/softfloat.mk
    • mk/toolchain.mk
    • src/emulate.c
    • src/riscv.h
    • src/softfloat
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful
    • Fb Infer (Static Code Analysis) - ✖︎ Failed

AI Code Review powered by Bito Logo

@jserv jserv force-pushed the modular-softfloat branch from 2b375ea to d3275eb Compare February 7, 2025 18:49
@bito-code-review
Copy link

bito-code-review bot commented Feb 7, 2025 •
edited
Loading

Code Review Agent Run #990067

Actionable Suggestions - 0
Review Details
  • Files reviewed - 7 · Commit Range: d3275eb..d3275eb
    • .gitmodules
    • Makefile
    • mk/softfloat.mk
    • mk/toolchain.mk
    • src/emulate.c
    • src/riscv.h
    • src/softfloat
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful
    • Fb Infer (Static Code Analysis) - ✖︎ Failed

AI Code Review powered by Bito Logo

@jserv jserv force-pushed the modular-softfloat branch from d3275eb to 8bcf084 Compare February 7, 2025 18:57
@bito-code-review
Copy link

bito-code-review bot commented Feb 7, 2025 •
edited
Loading

Code Review Agent Run #81a04a

Actionable Suggestions - 1
  • mk/softfloat.mk - 1
    • Consider grouping warning flags separately · Line 3-10
Review Details
  • Files reviewed - 7 · Commit Range: 8bcf084..8bcf084
    • .gitmodules
    • Makefile
    • mk/softfloat.mk
    • mk/toolchain.mk
    • src/emulate.c
    • src/riscv.h
    • src/softfloat
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful
    • Fb Infer (Static Code Analysis) - ✖︎ Failed

AI Code Review powered by Bito Logo

bito-code-review[bot]
bito-code-review bot reviewed Feb 7, 2025
View reviewed changes
@jserv jserv force-pushed the modular-softfloat branch from 8bcf084 to b41f6fa Compare February 7, 2025 19:05
@bito-code-review
Copy link

bito-code-review bot commented Feb 7, 2025 •
edited
Loading

Code Review Agent Run #917e75

Actionable Suggestions - 1
  • mk/softfloat.mk - 1
    • Missing line continuation character in makefile · Line 315-315
Review Details
  • Files reviewed - 7 · Commit Range: b41f6fa..b41f6fa
    • .gitmodules
    • Makefile
    • mk/softfloat.mk
    • mk/toolchain.mk
    • src/emulate.c
    • src/riscv.h
    • src/softfloat
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful
    • Fb Infer (Static Code Analysis) - ✖︎ Failed

AI Code Review powered by Bito Logo

@jserv jserv added this to the release-2025.1 milestone Feb 7, 2025
bito-code-review[bot]
bito-code-review bot reviewed Feb 7, 2025
View reviewed changes
@jserv jserv force-pushed the modular-softfloat branch from b41f6fa to ef87f7f Compare February 9, 2025 09:42
@bito-code-review
Copy link

bito-code-review bot commented Feb 9, 2025 •
edited
Loading

Code Review Agent Run #616a21

Actionable Suggestions - 0
Review Details
  • Files reviewed - 7 · Commit Range: ef87f7f..ef87f7f
    • .gitmodules
    • Makefile
    • mk/softfloat.mk
    • mk/toolchain.mk
    • src/emulate.c
    • src/riscv.h
    • src/softfloat
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful
    • Fb Infer (Static Code Analysis) - ✖︎ Failed

AI Code Review powered by Bito Logo

@jserv jserv force-pushed the modular-softfloat branch from ef87f7f to a31b62f Compare February 9, 2025 10:03
@bito-code-review
Copy link

bito-code-review bot commented Feb 9, 2025 •
edited
Loading

Code Review Agent Run #89500e

Actionable Suggestions - 0
Review Details
  • Files reviewed - 7 · Commit Range: a31b62f..a31b62f
    • .gitmodules
    • Makefile
    • mk/softfloat.mk
    • mk/toolchain.mk
    • src/emulate.c
    • src/riscv.h
    • src/softfloat
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful
    • Fb Infer (Static Code Analysis) - ✖︎ Failed

AI Code Review powered by Bito Logo

@jserv jserv force-pushed the modular-softfloat branch from a31b62f to e344fbb Compare February 9, 2025 14:57
@bito-code-review
Copy link

bito-code-review bot commented Feb 9, 2025 •
edited
Loading

Code Review Agent Run #620631

Actionable Suggestions - 0
Review Details
  • Files reviewed - 7 · Commit Range: e344fbb..e344fbb
    • .gitmodules
    • Makefile
    • mk/softfloat.mk
    • mk/toolchain.mk
    • src/emulate.c
    • src/riscv.h
    • src/softfloat
  • Files skipped - 1
    • .github/workflows/main.yml - Reason: Filter setting
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful
    • Fb Infer (Static Code Analysis) - ✖︎ Failed

AI Code Review powered by Bito Logo

@jserv jserv force-pushed the modular-softfloat branch from e344fbb to df51133 Compare February 9, 2025 15:13
@bito-code-review
Copy link

bito-code-review bot commented Feb 9, 2025 •
edited
Loading

Code Review Agent Run #c385ac

Actionable Suggestions - 0
Review Details
  • Files reviewed - 7 · Commit Range: df51133..df51133
    • .gitmodules
    • Makefile
    • mk/softfloat.mk
    • mk/toolchain.mk
    • src/emulate.c
    • src/riscv.h
    • src/softfloat
  • Files skipped - 1
    • .github/workflows/main.yml - Reason: Filter setting
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful
    • Fb Infer (Static Code Analysis) - ✖︎ Failed

AI Code Review powered by Bito Logo

@jserv jserv force-pushed the modular-softfloat branch 2 times, most recently from 391fe09 to 1b4168a Compare February 11, 2025 08:57
@bito-code-review
Copy link

bito-code-review bot commented Feb 11, 2025 •
edited
Loading

Code Review Agent Run #290fdf

Actionable Suggestions - 0
Review Details
  • Files reviewed - 7 · Commit Range: 1b4168a..1b4168a
    • .gitmodules
    • Makefile
    • mk/softfloat.mk
    • mk/toolchain.mk
    • src/emulate.c
    • src/riscv.h
    • src/softfloat
  • Files skipped - 1
    • .github/workflows/main.yml - Reason: Filter setting
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful
    • Fb Infer (Static Code Analysis) - ✖︎ Failed

AI Code Review powered by Bito Logo

@jserv jserv force-pushed the modular-softfloat branch from 1b4168a to 4bf975e Compare February 11, 2025 13:16
@bito-code-review
Copy link

bito-code-review bot commented Feb 11, 2025 •
edited
Loading

Code Review Agent Run #544aaf

Actionable Suggestions - 0
Review Details
  • Files reviewed - 7 · Commit Range: 4bf975e..4bf975e
    • .gitmodules
    • Makefile
    • mk/softfloat.mk
    • mk/toolchain.mk
    • src/emulate.c
    • src/riscv.h
    • src/softfloat
  • Files skipped - 1
    • .github/workflows/main.yml - Reason: Filter setting
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful
    • Fb Infer (Static Code Analysis) - ✖︎ Failed

AI Code Review powered by Bito Logo

@jserv jserv force-pushed the modular-softfloat branch from 4bf975e to 3753bb6 Compare February 11, 2025 14:09
@bito-code-review
Copy link

bito-code-review bot commented Feb 11, 2025 •
edited
Loading

Code Review Agent Run #964c58

Actionable Suggestions - 0
Review Details
  • Files reviewed - 7 · Commit Range: 3753bb6..3753bb6
    • .gitmodules
    • Makefile
    • mk/softfloat.mk
    • mk/toolchain.mk
    • src/emulate.c
    • src/riscv.h
    • src/softfloat
  • Files skipped - 1
    • .github/workflows/main.yml - Reason: Filter setting
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful
    • Fb Infer (Static Code Analysis) - ✖︎ Failed

AI Code Review powered by Bito Logo

@jserv jserv force-pushed the modular-softfloat branch from 3753bb6 to d2b6f95 Compare February 11, 2025 14:48
@bito-code-review
Copy link

bito-code-review bot commented Feb 11, 2025 •
edited
Loading

Code Review Agent Run #c6892e

Actionable Suggestions - 0
Review Details
  • Files reviewed - 7 · Commit Range: d2b6f95..d2b6f95
    • .gitmodules
    • Makefile
    • mk/softfloat.mk
    • mk/toolchain.mk
    • src/emulate.c
    • src/riscv.h
    • src/softfloat
  • Files skipped - 1
    • .github/workflows/main.yml - Reason: Filter setting
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful
    • Fb Infer (Static Code Analysis) - ✖︎ Failed

AI Code Review powered by Bito Logo

@jserv jserv force-pushed the modular-softfloat branch from d2b6f95 to 9941a43 Compare February 11, 2025 15:08
@bito-code-review
Copy link

bito-code-review bot commented Feb 11, 2025 •
edited
Loading

Code Review Agent Run #f28697

Actionable Suggestions - 0
Review Details
  • Files reviewed - 7 · Commit Range: 9941a43..9941a43
    • .gitmodules
    • Makefile
    • mk/softfloat.mk
    • mk/toolchain.mk
    • src/emulate.c
    • src/riscv.h
    • src/softfloat
  • Files skipped - 1
    • .github/workflows/main.yml - Reason: Filter setting
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful
    • Fb Infer (Static Code Analysis) - ✖︎ Failed

AI Code Review powered by Bito Logo

@jserv jserv force-pushed the modular-softfloat branch 2 times, most recently from a766f44 to cad7886 Compare February 11, 2025 15:22
@bito-code-review
Copy link

bito-code-review bot commented Feb 11, 2025 •
edited
Loading

Code Review Agent Run #4532de

Actionable Suggestions - 0
Review Details
  • Files reviewed - 7 · Commit Range: cad7886..cad7886
    • .gitmodules
    • Makefile
    • mk/softfloat.mk
    • mk/toolchain.mk
    • src/emulate.c
    • src/riscv.h
    • src/softfloat
  • Files skipped - 1
    • .github/workflows/main.yml - Reason: Filter setting
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful
    • Fb Infer (Static Code Analysis) - ✖︎ Failed

AI Code Review powered by Bito Logo

@jserv jserv force-pushed the modular-softfloat branch from cad7886 to 40a4e4e Compare February 11, 2025 15:24
@bito-code-review
Copy link

bito-code-review bot commented Feb 11, 2025 •
edited
Loading

Code Review Agent Run #ee8612

Actionable Suggestions - 0
Review Details
  • Files reviewed - 7 · Commit Range: 40a4e4e..40a4e4e
    • .gitmodules
    • Makefile
    • mk/softfloat.mk
    • mk/toolchain.mk
    • src/emulate.c
    • src/riscv.h
    • src/softfloat
  • Files skipped - 1
    • .github/workflows/main.yml - Reason: Filter setting
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful
    • Fb Infer (Static Code Analysis) - ✖︎ Failed

AI Code Review powered by Bito Logo

@jserv jserv force-pushed the modular-softfloat branch from 40a4e4e to 51f0366 Compare February 11, 2025 16:26
@bito-code-review
Copy link

bito-code-review bot commented Feb 11, 2025 •
edited
Loading

Code Review Agent Run #d78dc4

Actionable Suggestions - 0
Review Details
  • Files reviewed - 7 · Commit Range: 51f0366..51f0366
    • .gitmodules
    • Makefile
    • mk/softfloat.mk
    • mk/toolchain.mk
    • src/emulate.c
    • src/riscv.h
    • src/softfloat
  • Files skipped - 1
    • .github/workflows/main.yml - Reason: Filter setting
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful
    • Fb Infer (Static Code Analysis) - ✖︎ Failed

AI Code Review powered by Bito Logo

@jserv
Use upstream SoftFloat and unify build system
edfa83e 
Replace custom Berkeley SoftFloat 3 package in 'src/softfloat' with the
upstream one. It streamlines build system onfiguration for consistency.
@jserv jserv force-pushed the modular-softfloat branch from 51f0366 to edfa83e Compare February 12, 2025 02:11
@bito-code-review
Copy link

bito-code-review bot commented Feb 12, 2025 •
edited
Loading

Code Review Agent Run #f400c9

Actionable Suggestions - 0
Review Details
  • Files reviewed - 7 · Commit Range: edfa83e..edfa83e
    • .gitmodules
    • Makefile
    • mk/softfloat.mk
    • mk/toolchain.mk
    • src/emulate.c
    • src/riscv.h
    • src/softfloat
  • Files skipped - 1
    • .github/workflows/main.yml - Reason: Filter setting
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful
    • Fb Infer (Static Code Analysis) - ✖︎ Failed

AI Code Review powered by Bito Logo

@jserv jserv merged commit bdfa187 into master Feb 12, 2025
17 of 19 checks passed
@jserv jserv deleted the modular-softfloat branch February 12, 2025 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@bito-code-review bito-code-review[bot] bito-code-review[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

release-2025.1

Development

Successfully merging this pull request may close these issues.

2 participants

@jserv