Skip to content

Conversation

@bazsi
Copy link
Collaborator

@bazsi bazsi commented Feb 7, 2019

Signed-off-by: Balazs Scheidler [email protected]

@kira-syslogng
Copy link
Contributor

Build SUCCESS

@bazsi
Copy link
Collaborator Author

bazsi commented Feb 7, 2019 via email

@kira-syslogng
Copy link
Contributor

Build SUCCESS

Copy link
Collaborator

@gaborznagy gaborznagy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please include the new scl in these files too:

  • packaging/debian/syslog-ng-core.install
  • scl/CMakeLists.txt

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please link a reference document for netskope log format? I have not found any with a quick search.
It seems that "<134>" is hard coded to every message, and _insertion_epoch_timestamp is a fingerprint as well.

@bazsi
Copy link
Collaborator Author

bazsi commented Feb 8, 2019 via email

Signed-off-by: Balazs Scheidler <[email protected]>
@kira-syslogng
Copy link
Contributor

Build SUCCESS

@gaborznagy
Copy link
Collaborator

Both of these are true observations. This is a heuristics to fix the logs coming from Netskope and the format is potentially not documented and can change any time.

Then is it worth to include something fragile into default-network-drivers via app-parser?
How are we gonna test that it's broken?

It sound to me, that the netskope-parser is enough.
I know, Cisco is the same: it uses heuristics and the format can broke as well, but integrating that many things by default that can broke easily seems to be hard to maintain.

@bazsi
Copy link
Collaborator Author

bazsi commented Feb 8, 2019

Then is it worth to include something fragile into default-network-drivers via app-parser?
How are we gonna test that it's broken?

Well, we won't. These are "as is" contributions that anyone is welcome to adapt to their own liking and PRs are appreciated. Bugreports are also appreciated, which we should handle on a best effort basis.

Usually though, if there's a problem, we already have a log sample to fix the parser with. So in fact, these kind of bugreports are a good source of getting log samples :)

And these kind of support levels are pretty standard, log formats are breaking everywhere, still the value that we deliver is that we compiled them to make it easy to use and then make it easy to fix/upgrade.

@gaborznagy gaborznagy changed the title scl: add parser for netskope logs WIP: scl: add parser for netskope logs Feb 14, 2019
@bazsi
Copy link
Collaborator Author

bazsi commented Feb 17, 2019

@MrAnno was nice enough to fix the outstanding issues which I have added to this branch.

Removing wip

@bazsi bazsi changed the title WIP: scl: add parser for netskope logs scl: add parser for netskope logs Feb 17, 2019
@kira-syslogng
Copy link
Contributor

Build SUCCESS

@Kokan Kokan merged commit f5764bc into syslog-ng:master Feb 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants