riemann: fix ref/unref-ing templates #2514
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting the values of riemann driver calls `log_template_ref`, which must be unref'd after (in the ym file). I have seen this behavior in other drivers, too: afsmtp, http, msg-generator Signed-off-by: Attila Szakacs <[email protected]>
MrAnno
approved these changes
Jan 28, 2019
Collaborator
MrAnno
left a comment
MrAnno
left a comment
There was a problem hiding this comment.
👍
I think redis is affected too.
Contributor
|
Build SUCCESS |
Collaborator
Author
I will check tomorrow, and open a PR, if that is the case. :) |
furiel
approved these changes
Jan 29, 2019
Collaborator
|
hmm... we should probably add a riemann_set_XXX_ref() function that consumes the ref that gets That's the pattern when the call-site has a ref that would need to be unrefed. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting the values of riemann driver calls
log_template_ref, which must be unref'd after (in the ym file).Previously it was not unref'd, which caused memory leak every reload, because at
riemann_dd_free(), the ref counters were 2.I have seen this behavior in other drivers, too:
afsmtp, http, msg-generator
Signed-off-by: Attila Szakacs [email protected]