Skip to content

Conversation

@mauricetmeyer
Copy link
Contributor

No description provided.

@kira-syslogng
Copy link
Contributor

This user does not have permission to start the build. Can one of the admins verify this patch and start the build?
(admin: you have the next options (make sure you checked the code):
"ok to test" to accept this pull request (and further changes) for testing
"test this please" for a one time test run
do nothing -> CI won't start)

1 similar comment
@kira-syslogng
Copy link
Contributor

This user does not have permission to start the build. Can one of the admins verify this patch and start the build?
(admin: you have the next options (make sure you checked the code):
"ok to test" to accept this pull request (and further changes) for testing
"test this please" for a one time test run
do nothing -> CI won't start)

@MrAnno
Copy link
Collaborator

MrAnno commented Oct 1, 2018

@kira-syslogng test this please

@kira-syslogng
Copy link
Contributor

Build SUCCESS

Kokan
Kokan previously approved these changes Oct 2, 2018
szemere
szemere previously approved these changes Oct 2, 2018
Copy link
Collaborator

@szemere szemere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional changes: (sorry for the nitpicking) The files contains mixed spaces and tabs. This is why the indentation misalligned on GitHub. Could you please choose one, and update the PR?

@mauricetmeyer
Copy link
Contributor Author

@szemere Sure, didn't notice that for some reason. Thanks for pointing that out, probably have to check my editor config.

@mauricetmeyer mauricetmeyer dismissed stale reviews from szemere and Kokan via 5ac3f2e October 2, 2018 08:06
@szemere szemere merged commit d7c70cf into syslog-ng:master Oct 3, 2018
@MrAnno
Copy link
Collaborator

MrAnno commented Oct 3, 2018

@mauricetmeyer Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants