logreader+logwriter: timeout support #2056
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Build SUCCESS |
MrAnno
approved these changes
May 25, 2018
szemere
reviewed
May 25, 2018
lib/logwriter.c
Outdated
Collaborator
There was a problem hiding this comment.
I think this casting can be omitted.
Collaborator
There was a problem hiding this comment.
In syslog-ng most of the timer handler are set in this way (but agreed: it's not mandatory... the signature of this handler is a matching signature) and in logreader it is set without the cast.
Signed-off-by: László Várady <[email protected]>
Signed-off-by: Antal Nemes <[email protected]>
Signed-off-by: Antal Nemes <[email protected]>
Contributor
|
Build SUCCESS |
1 similar comment
Contributor
|
Build SUCCESS |
lbudai
approved these changes
May 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LogProto can now express an idle timeout during prepare. When the timeout elapsed, logwriter/logreader will close the controlling pipe.
Credits for @MrAnno for the logwriter part.