Skip to content

Bugfix: watchRunHook race condition periodically breaks change detection triggered by writeModule (webpack@4) #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
idpbond wants to merge 1 commit into from
Closed

Bugfix: watchRunHook race condition periodically breaks change detection triggered by writeModule (webpack@4) #82

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,7 @@ class VirtualModulesPlugin {
birthtime: date,
});
const modulePath = getModulePath(filePath, this._compiler);
const fts = this._compiler.fileTimestamps as any;

if (process.env.DEBUG)
// eslint-disable-next-line no-console
Expand Down Expand Up @@ -166,6 +167,9 @@ class VirtualModulesPlugin {
if (process.env.DEBUG)
// eslint-disable-next-line no-console
console.log(this._compiler.name, 'Emit file change:', modulePath, time);

if (fts && typeof fts.set === 'function' && fts.get(modulePath)) fts.set(modulePath, time);

delete fileWatcher.directoryWatcher._cachedTimeInfoEntries;
fileWatcher.directoryWatcher.setFileTime(filePath, time, false, false, null);
fileWatcher.emit('change', time, null);
Expand Down