Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post module refactor #322

Merged
merged 1 commit into from
Sep 4, 2017
Merged

Post module refactor #322

merged 1 commit into from
Sep 4, 2017

Conversation

mitjade
Copy link
Collaborator

@mitjade mitjade commented Aug 24, 2017

on post add remain on page

@mitjade
Copy link
Collaborator Author

mitjade commented Aug 24, 2017

@mairh I managed to combine post add and edit page and create a transition without blinking, for both web and mobile. Could you take a look, if this is something you intended when we ware discussing this a while back.

I still need to implement nested mutations, so you would be able to add comments before first save, but maybe this is already better to what we have now.

I also plan to add two buttons Save and Save and list to be able to skip one click in case you want to also go back to list.

@mitjade mitjade requested a review from mairh August 24, 2017 18:47
@mairh
Copy link
Member

mairh commented Aug 24, 2017

I will have a look tomorrow morning. Thanks for the PR

@larixer larixer mentioned this pull request Aug 31, 2017
28 tasks
@larixer
Copy link
Member

larixer commented Sep 4, 2017

@mairh Are you still going to take a look or should we merge this one?

@mairh
Copy link
Member

mairh commented Sep 4, 2017

I apologize I was too busy to look into it. I will surely review it today and merge it.

@mitjade
Copy link
Collaborator Author

mitjade commented Sep 4, 2017

@Vlasenko I still plan to do some work on this refactoring post example, after I'm done with auth, but in it's current state can already be merged if anyone would find it useful.

@mairh
Copy link
Member

mairh commented Sep 4, 2017

It looks good. I will merge it

We can take the next 2 points later on when you are done with auth stuff

Quote 1: I still need to implement nested mutations, so you would be able to add comments before first save, but maybe this is already better to what we have now.

Quote 2: I also plan to add two buttons Save and Save and list to be able to skip one click in case you want to also go back to list.

@mairh mairh closed this Sep 4, 2017
@mairh mairh reopened this Sep 4, 2017
@mairh mairh merged commit bbcd52a into master Sep 4, 2017
@larixer larixer deleted the post-module-refactor branch September 14, 2017 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants