🌱 Fix tests. #47
Merged
🌱 Fix tests. #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These e2e tests seem to be hard-coded to a specific environment. I tried to get them running with a kind cluster, but failed.
janiskemper
reviewed
Dec 12, 2024
hcloud/util.go
Outdated
| @@ -101,6 +104,9 @@ func getRobotServerByID(c robotclient.Client, id int, node *corev1.Node) (*model | |||
| } | |||
|
|
|||
| // check whether name matches - otherwise this server does not belong to the respective node anymore | |||
| if server == nil { | |||
There was a problem hiding this comment.
this shouldn't happen right? If there is an error code for "server not found"?
There was a problem hiding this comment.
If the error code was "server not found", then a nil pointer exception happens, because server was nil.
I made the old code easier to read. It now looks like this:
server, err := c.ServerGet(id)
if models.IsError(err, models.ErrorCodeServerNotFound) {
return nil, nil
}
if err != nil {
hcops.HandleRateLimitExceededError(err, node)
return nil, fmt.Errorf("%s: %w", op, err)
}
// check whether name matches - otherwise this server does not belong to the respective node anymore
if server.Name != node.Name {
return nil, nil
}The old check looked like this:
if err != nil && !models.IsError(err, models.ErrorCodeServerNotFound) {Is that ok for you?
janiskemper
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix tests.
Up to now, they failed like this: