Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Set condition to false if server resource unavailable #1394

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

Dhairya-Arora01
Copy link
Contributor

What this PR does / why we need it: mark hcloud machine's "serverCreateSucceeded" condition to false if it throws server resource unavailable error

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squash commits
  • include documentation
  • add unit tests

mark hcloud machine's "serverCreateSucceeded" condition to false if it
throws server resource unavailable error

Signed-off-by: Dhairya Arora <[email protected]>
@Dhairya-Arora01 Dhairya-Arora01 marked this pull request as ready for review July 25, 2024 16:17
@syself-bot syself-bot bot added area/code Changes made in the code directory area/api Changes made in the api directory labels Jul 25, 2024
@batistein batistein merged commit d3bd5b5 into main Jul 25, 2024
12 of 14 checks passed
@batistein batistein deleted the dhairya/resourceUnavailable branch July 25, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api Changes made in the api directory area/code Changes made in the code directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants