ci: Add Makefile and move some content from pre-commit #121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tembleking
changed the title
tembleking
force-pushed
the
ci-add-makefile
branch
from
f4808d0 to
b2ad048
Compare
Comment on lines
+1
to
+6
| deps: | ||
| go install github.com/terraform-docs/[email protected] | ||
| go install github.com/hashicorp/terraform-config-inspect@latest | ||
| curl -L "`curl -s https://api.github.com/repos/terraform-linters/tflint/releases/latest | grep -o -E "https://.+?_linux_amd64.zip"`" -o tflint.zip && \ | ||
| unzip tflint.zip && \ | ||
| rm tflint.zip && \ |
Contributor
There was a problem hiding this comment.
thaaanks! always forget that when installing requirements automatization >>>> docs.
- should not we modify the "Install pre-commit dependencies" in the
.pre-commit-config.yamlfile to use thisdepsstep?
Member
Author
There was a problem hiding this comment.
There's no step in the pre-commit-config, right?
wideawakening
approved these changes
Sep 2, 2022
Contributor
There was a problem hiding this comment.
thx @tembleking 💪🏽
- why make and not just? thought you already made the switch ;)
- added some notes on using make steps on the GH actions
- to push the homogenization of the three modules i would suggest doing this changes in AWS and Azure too + update the CONTRIBUTE.md of the three
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.