fix(modular): make account alias optional in onboarding module #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgeers
approved these changes
Oct 10, 2024
jose-pablo-camacho
deleted the
fix/module-onboarding/make-alias-optional
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref: https://sysdig.atlassian.net/browse/SSPROD-47600
This PR makes the
aws account aliasas optional since theaws_iam_account_aliasdatasource is broken as mentioned within the ticket above.Before doing this, some steps were tried however there's no solution yet:
null_resourcewithout having the user install additional tooling - Not possible.Finally, while we wait on the provider to be fixed or do it on the BE, we want to avoid the error for accounts without alias by making it an optional variable.