enhance(modular): handle deprecated resources in modules #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haresh-suresh
approved these changes
Oct 8, 2024
Contributor
haresh-suresh
left a comment
haresh-suresh
left a comment
There was a problem hiding this comment.
Nicely done !
LGTM
Let's make sure to publish using the tags format we have 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref: https://sysdig.atlassian.net/browse/SSPROD-47604
This PR has some fixes to avoid warnings around deprecated resources in TF to avoid
warningsfor the user.Leverages the use of
aws_iam_role_policyinstead ofinline_policyattributes, this was tested for single and organization forFoundational+CDR/CIEM+VMand run the validation manually too.