-
-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix screen large items #472
base: main
Are you sure you want to change the base?
Conversation
WalkthroughThe pull request modifies the layout configurations in two components: Changes
Assessment against linked issues
Possibly related PRs
Suggested reviewers
Security Recommendations🔒 Security Insights:
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Least common multiple is 30 for cols if 2, 3 or 5.
Come on, folks, this is a no-brainer... :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lint must pass before we can merge (we are ignoring the failed PR builds at this moment)
Hey! Apologies for the delays on this one, work has been quite manic of late, including some very long hours. Are you able to review the linting errors as @tankerkiller125 has pointed out, and we'll get this one tested and merged @webysther ? |
No, I need to build again, looks like this link is not related to my code, I think this linter run on the file that have changes wich sounds strange but I will fix that, give me one day. |
What type of PR is this?
feature
What this PR does / why we need it:
improve list items on large screen
change the default pageSize to 30 because is Least common multiple of 2, 3 and 5.
Which issue(s) this PR fixes:
Closes #469
Before:
After:
Summary by CodeRabbit