Remove Logo size

[katosdev]

What type of PR is this?

• bug

What this PR does / why we need it:

Due to misplaced logo components, reverting change to add sizing whilst further investigation is conducted.

Which issue(s) this PR fixes:

Revert fix for Safari logo not showing due to placement issues of the logo.

Summary by CodeRabbit

• New Features

  • Enhanced scalability of the logo by removing fixed height and width attributes from the SVG.

• Bug Fixes

  • Ensured the logo maintains its design and functionality while allowing for better responsiveness.

[coderabbitai]

Walkthrough

The pull request modifies the Logo.vue component by removing explicit height and width attributes from the SVG element. This change allows the SVG to dynamically scale based on its viewBox dimensions, providing more flexible rendering across different contexts without fixed pixel constraints. The core structure and design of the logo remain intact.

Changes

File	Change Summary
frontend/components/App/Logo.vue	Removed fixed height and width attributes from <svg> element, enabling dynamic scaling

Suggested reviewers

• tankerkiller125
• tonyaellie

Security Recommendations

🔒 Security Insights for SVG Modifications:

1. Ensure SVG sanitization is in place to prevent potential XSS vulnerabilities when dynamically rendering SVG elements.
2. Validate that removing fixed dimensions doesn't introduce unexpected layout shifts or rendering issues.
3. Consider implementing Content Security Policy (CSP) headers to mitigate risks associated with inline SVG rendering.

Possibly related PRs

• Update Logo.vue #400: Previously added height and width attributes to the <svg> element in Logo.vue
• FIX: Set SVG logo size to fix logo not showing on Safari #402: Explored CSS-based sizing for SVG elements
• FIX: Homebox SVG logo missing in Safari due to size not specified #406: Another PR dealing with SVG size attributes in Logo.vue

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2f7d7cf and 7d955e4.

📒 Files selected for processing (1)

• frontend/components/App/Logo.vue (0 hunks)

💤 Files with no reviewable changes (1)

• frontend/components/App/Logo.vue

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.