Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve deprecation warning for Python 3.9 #11

Merged
merged 1 commit into from
Oct 19, 2020

Conversation

nerdstrike
Copy link
Contributor

Python 3.8 creates warnings that fail on stringent testing:

`aiodataloader.py:2: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated since Python 3.3, and in 3.9 it will stop working
from collections import Iterable, namedtuple

-- Docs: https://docs.pytest.org/en/latest/warnings.html`

@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 91.509% when pulling 13e696e on nerdstrike:master into 9f55487 on syrusakbary:master.

@ahopkins
Copy link

I just came to make this same PR, and I see it has been sitting here for a few months already.

Is this project dead? Do you need someone to take it over or help keep it moving?

@AutumnalDream
Copy link

@syrusakbary This project dead?

@ahopkins
Copy link

I'm thinking of forking and releasing if it is.

@syrusakbary
Copy link
Owner

Sorry for the delay, I've been working in other stuff. This PR looks good to merge

@syrusakbary syrusakbary merged commit 0345c66 into syrusakbary:master Oct 19, 2020
@ahopkins
Copy link

@syrusakbary Understandable. It is, afterall, the nature of open source. If you need any help maintaining, please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants