Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Spec] MSC2285 Stable/Unstable crossover period support #717

Merged
merged 13 commits into from
Sep 11, 2022
Merged

[Spec] MSC2285 Stable/Unstable crossover period support #717

merged 13 commits into from
Sep 11, 2022

Conversation

EdGeraghty
Copy link
Collaborator

@EdGeraghty EdGeraghty commented Aug 19, 2022 •
edited
Loading

Types

  • Fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Refactor (non-breaking change which improves code quality - QA thoroughly )
  • Breaking Change (fix or feature that would cause existing functionality to not work as expected)
  • Chore (updates that would not affect or change the code involving the app itself)

Changes

🔮 Features

🐛 Fixes

🔒 Security

🛠 Performance

📐 Refactoring

Media (if applicable)

QA

  • Signup
  • Login
  • Logout
  • Unencrypted Chat
  • Encrypted Chat
  • Group Chats
  • Profile Changes
  • Theming Changes
  • Force Kill and Restart

Final Checklist

  • All associated issues have been linked to PR
  • All necessary changes made to the documentation
  • Parties interested in these changes have been notified
  • Linter has been run on all code in the PR

@EdGeraghty EdGeraghty linked an issue Aug 19, 2022 that may be closed by this pull request
Move to stable prefix for Private Read Receipts #716
Closed
@EdGeraghty EdGeraghty marked this pull request as ready for review August 20, 2022 11:35
@EdGeraghty EdGeraghty requested a review from ereio as a code owner August 20, 2022 11:35
ereio
ereio reviewed Sep 11, 2022
View reviewed changes
lib/store/settings/theme-settings/selectors.dart
case ReadReceiptTypes.Private:
return Strings.labelPrivate;

default: //I've not been coded for this one yet
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the functionality expected behind this one?

Copy link
Collaborator Author

@EdGeraghty EdGeraghty Sep 11, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Purely defensive. The only two in the spec (on and private) + Off are handled above it. Feel free to patch out as wanted, it's on origin

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note this is purely to handle string translation

ereio
ereio reviewed Sep 11, 2022
View reviewed changes
Copy link
Member

@ereio ereio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the question I posted, this looks good. Great work!

Once that's clear, will approve. Can we set the switch block default to return Strings.labelOn? I'm assuming the actual default setting will still be "Off" correct?

@ereio ereio self-requested a review September 11, 2022 19:40
ereio
ereio approved these changes Sep 11, 2022
View reviewed changes
Copy link
Member

@ereio ereio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@EdGeraghty EdGeraghty merged commit 142adb5 into dev Sep 11, 2022
@EdGeraghty EdGeraghty deleted the spec/msc2285-stable branch September 11, 2022 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ereio ereio ereio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move to stable prefix for Private Read Receipts
2 participants
@EdGeraghty @ereio