Skip to content

Commit

Permalink
TODO
Browse files Browse the repository at this point in the history
  • Loading branch information
syphar committed Dec 6, 2024
1 parent 84e002f commit 15bf301
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 0 deletions.
20 changes: 20 additions & 0 deletions TODO.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
# idea

## phase 1

- add rustdoc_status & doc_targets to builds table, since it might change with
the build
- finish_release can be more intelligent when updating rustdoc_status &
doc_targets, not updating it when the build failed, and there is an existing
successful build?
- then we can start rebuilds again
- run a query to past releases to where we have more than one build, at least
one is successful, and we have rustdoc_status = false? Is this enough? How to
exclude binaries / non-libs?

## phase 2

- backfill the new build fields from the releases table
- add calculated summary fields for these in release_build_status
- backfill these too
- drop the fields from releases, use the release_build_status
2 changes: 2 additions & 0 deletions src/db/add_package.rs
Original file line number Diff line number Diff line change
Expand Up @@ -255,6 +255,8 @@ pub(crate) async fn finish_build(
rustc_version: &str,
docsrs_version: &str,
build_status: BuildStatus,
doc_targets: Option<Vec<String>>,
has_docs: Option<bool>,
documentation_size: Option<u64>,
errors: Option<&str>,
) -> Result<()> {
Expand Down

0 comments on commit 15bf301

Please sign in to comment.