Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flexporter updates - October 2024 #1525

Merged
merged 4 commits into from
Oct 31, 2024
Merged

Conversation

dehall
Copy link
Contributor

@dehall dehall commented Oct 29, 2024

A few new features for the flexporter:

  1. A new if field that can be used in create_resource to conditionally set a field. The use case that inspired this is shown in the unit test - creating ServiceRequest based on Procedure, setting ServiceRequest.authoredOn = Procedure.performed, but Procedure.performed is either a dateTime (ie, primitive) or a Period (ie, an object) so the types need different handling. Previously the only way to do this was with two separate actions with different applicability.
  2. Allow deleting resources by FHIRPath instead of just by resource type. The use case that inspired this is deleting some of the SDOH conditions to clean up a record for a demo
  3. Allow functions to be nested within definitions. Previously a function call such as getAttribute could only be used as the top-level value, now value can be a map and one of the sub-values can be the function.

Copy link
Member

@jawalonoski jawalonoski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor checkstyle issues:

[ant:checkstyle] [WARN] synthea/src/test/java/org/mitre/synthea/export/flexporter/ActionsTest.java:63: Wrong lexicographical order for 'ca.uhn.fhir.parser.IParser' import. Should be before 'org.mitre.synthea.world.agents.Person'. [CustomImportOrder]
[ant:checkstyle] [WARN] synthea/src/test/java/org/mitre/synthea/export/flexporter/ActionsTest.java:517:15: Local variable name 'cOut' must match pattern '^[a-z]([a-z0-9][a-zA-Z0-9]*)?$'. [LocalVariableName]

@dehall
Copy link
Contributor Author

dehall commented Oct 31, 2024

Addressed checkstyle issues - not sure why that IParser import even moved in the first place

@jawalonoski jawalonoski merged commit e2ca05d into master Oct 31, 2024
4 checks passed
@jawalonoski jawalonoski deleted the flexporter_updates_2024_10 branch October 31, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants