Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for allowDashes #3

Closed

Conversation

jeremyhansonfinger
Copy link

Problem

We want retext-shopify, which is based on retext-simplify, not to strip out hyphens when performing matches. For instance, we want to be able to tell people that drop-down menu is the preferred spelling, rather than drop down menu or dropdown menu.

Solution

We added the ability to set allowDashes value (see syntax-tree/nlcst-normalize#1 ) when calling the search() function.

Notes

As in syntax-tree/nlcst-normalize#1, Dave notes that the test coverage may be excessive, but since he used these tests to resolve the problem I was having, he left them in there.

@jeremyhansonfinger
Copy link
Author

jeremyhansonfinger commented May 9, 2016

Travis CI won't pass unless the corresponding changes are merged into nlcst-normalize. @admhlt

@wooorm
Copy link
Member

wooorm commented May 11, 2016

Thanks a lot y’all!

@wooorm wooorm closed this in b7110fa May 14, 2016
@wooorm
Copy link
Member

wooorm commented May 14, 2016

Thanks both, released!

@jeremyhansonfinger
Copy link
Author

Great! Thanks again.

@wooorm wooorm added ⛵️ status/released 🗄 area/interface This affects the public interface 🦋 type/enhancement This is great to have 🧒 semver/minor This is backwards-compatible change labels Aug 11, 2019
@wooorm wooorm added the 💪 phase/solved Post is done label Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🗄 area/interface This affects the public interface 💪 phase/solved Post is done 🧒 semver/minor This is backwards-compatible change 🦋 type/enhancement This is great to have
Development

Successfully merging this pull request may close these issues.

2 participants