Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing remark-lint-list-item-indent in devDependencies #5

Conversation

aheissenberger
Copy link

Initial checklist

  • [X ] I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

add missing remark-lint-list-item-indent to devDependencies in package.json

Error Message:

$ pnpm test

> [email protected] test /Users/ah/SVN-Checkouts/TST/mdast-zone
> npm run build && npm run format && npm run test-coverage


> [email protected] build
> tsc --build --clean && tsc --build && type-coverage

(385 / 385) 100.00%
type-coverage success.

> [email protected] format
> remark . -qfo && prettier . -w --log-level warn && xo --fix

readme.md
 error Cannot process file
  [cause]:
    Error: Cannot find module `remark-lint-list-item-indent`

@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Sep 4, 2024
@ChristianMurphy
Copy link
Member

Welcome @aheissenberger! 👋

Taking a step back.

  1. I notice you are using pnpm, that depedency manager has different resolution rules than npm or yarn that may be the source of the issue
  2. If you do believe this is an issue with a unified project and not pnpm, that dependency is a transitive of remark-preset-wooorm
    1. the version of the preset here is a major version behind, consider updating remark-cli, remark-gfm, and remark-preset-wooorm to the latest major version instead
    2. If the issue still presists after upgrading the major versions, open a PR to https://www.npmjs.com/package/remark-preset-wooorm

@ChristianMurphy ChristianMurphy added the 👀 no/external This makes more sense somewhere else label Sep 4, 2024

This comment has been minimized.

@github-actions github-actions bot added 👎 phase/no Post cannot or will not be acted on and removed 🤞 phase/open Post is being triaged manually labels Sep 4, 2024
@wooorm
Copy link
Member

wooorm commented Sep 5, 2024

I’ve updated the deps in ddf0530. But yes: we use npm to maintain our things. If you’re checking out our projects, I recommend using that.

@aheissenberger
Copy link
Author

But yes: we use npm to maintain our things. If you’re checking out our projects, I recommend using that.

If npm is a requirement please add property "packageManager" to package.json.

Thanks for the quick response and your projects!
Andreas

@wooorm
Copy link
Member

wooorm commented Sep 6, 2024

Not sure that does what you want: nodejs/node#51888.

That field is also very experimental.

And wasn’t corepack going away?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👀 no/external This makes more sense somewhere else 👎 phase/no Post cannot or will not be acted on
Development

Successfully merging this pull request may close these issues.

3 participants