fix: roll back electrum connection on failure #261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwltr
changed the title
pwltr
force-pushed
the
fix/electrum-settings
branch
from
0bc3a7c to
7fa83fc
Compare
This was referenced Dec 3, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds robust error handling for Electrum server connections by implementing rollback to the last working configuration on connection failures. Key changes include passing connection protocol (tcp:// or ssl://) to ldk-node, validating connections before saving configuration, and keeping app status synchronized during connection changes. The PR also improves UI usability by making the keyboard dismissible via scroll and tap gestures.
- Adds connection validation and rollback mechanism when Electrum server changes fail
- Updates protocol handling to pass full URLs with tcp:// or ssl:// prefixes to ldk-node
- Synchronizes wallet state after connection changes to keep UI status accurate
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| ElectrumSettingsScreen.swift | Adds keyboard dismissal functionality and wallet state synchronization after connection changes |
| WalletViewModel.swift | Updates to use fullUrl property and adds lifecycle state synchronization in syncNodeStatus |
| SettingsViewModel.swift | Replaces protocol prefix concatenation with fullUrl property usage |
| SettingsViewModel+Rgs.swift | Updates RGS configuration to use fullUrl property |
| SettingsViewModel+Electrum.swift | Implements connection validation and rollback logic, adds protocol prefix parsing for QR codes |
| LightningService.swift | Adds error handling with recovery via restartWithPreviousConfig method |
| ElectrumConfigService.swift | Updates default server parsing to handle protocol prefixes |
| ElectrumServer.swift | Adds fullUrl computed property for protocol-prefixed URLs |
| Env.swift | Updates default Electrum server URLs to include protocol prefixes |
jvsena42
approved these changes
Dec 3, 2025
Contributor
Author
|
@piotr-iohk Can I merge or do I need to rerun e2e tests first? |
Collaborator
Good to merge, tests are updated and green. |
piotr-iohk
approved these changes
Dec 3, 2025
BitcoinErrorLog
pushed a commit
to BitcoinErrorLog/bitkit-ios
that referenced
this pull request
Dec 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Linked Issues/Tasks
Closes #256 #257
Screenshot / Video
Simulator.Screen.Recording.-.iPhone.17.-.2025-12-03.at.12.21.50.mov