Skip to content

Integrate LDK onchain events #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ovitrif merged 20 commits into from
Nov 28, 2025
Merged

Integrate LDK onchain events #245

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
c9c0f14
Integrate LDK onchain events
ben-kaufman Nov 26, 2025
7daff7d
Auto sync activities list
ben-kaufman Nov 26, 2025
8a15c01
Merge branch 'master' into feat/onchain-events
ben-kaufman Nov 26, 2025
47e13c0
Improve onchain tx search by id
ben-kaufman Nov 26, 2025
4e7b391
Update project.pbxproj
ben-kaufman Nov 26, 2025
4f15e14
fix: swift cached package manager invalidation on changes
jvsena42 Nov 26, 2025
01011de
Localizations and fix boost on removed tx
ben-kaufman Nov 26, 2025
b631252
ReceivedTransaction and ReceivedTransactionButton
piotr-iohk Nov 26, 2025
61b45a5
Add toast accessibility identifiers
ben-kaufman Nov 26, 2025
4a758d2
fix: include package.resolved on cache key
jvsena42 Nov 26, 2025
f057bdb
fix: remove cache temprarily
jvsena42 Nov 26, 2025
61818b1
Auto update activity details screen
ben-kaufman Nov 26, 2025
5adc1f6
fix: remove spm packages
jvsena42 Nov 27, 2025
4ab3122
Remove tx confirmed toast
ben-kaufman Nov 27, 2025
2ce3f03
Delete boosted activity and pass tags for replaced txs
ben-kaufman Nov 27, 2025
574a8f9
Filter RBF txs
ben-kaufman Nov 27, 2025
7f7076d
Fix RBF until events arrive
ben-kaufman Nov 27, 2025
ab36651
Merge pull request #247 from synonymdev/fix/rbf-display
ben-kaufman Nov 27, 2025
1b49bd8
feat: Show CPFC txs as boost fee
ben-kaufman Nov 27, 2025
4b9083d
Merge pull request #249 from synonymdev/feat/cpfp-boost-fee-ui
ovitrif Nov 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/integration-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ jobs:
- name: Install dependencies
run: |
echo "⏱️ Starting dependency resolution at $(date)"
xcodebuild -resolvePackageDependencies | xcbeautify
xcodebuild -resolvePackageDependencies -onlyUsePackageVersionsFromResolvedFile | xcbeautify
echo "✅ Dependencies resolved at $(date)"

- name: Pre-start simulator
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/unit-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ jobs:
- name: Install dependencies
run: |
echo "⏱️ Starting dependency resolution at $(date)"
xcodebuild -resolvePackageDependencies | xcbeautify
xcodebuild -resolvePackageDependencies -onlyUsePackageVersionsFromResolvedFile | xcbeautify
echo "✅ Dependencies resolved at $(date)"

- name: Pre-start simulator
Expand Down
2 changes: 0 additions & 2 deletions Bitkit.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,6 @@
Services/MigrationsService.swift,
Services/ServiceQueue.swift,
Services/VssStoreIdProvider.swift,
Utilities/AddressChecker.swift,
Utilities/Crypto.swift,
Utilities/Errors.swift,
Utilities/Keychain.swift,
Expand All @@ -118,7 +117,6 @@
Services/LightningService.swift,
Services/ServiceQueue.swift,
Services/VssStoreIdProvider.swift,
Utilities/AddressChecker.swift,
Utilities/Crypto.swift,
Utilities/Errors.swift,
Utilities/Keychain.swift,
Expand Down
6 changes: 3 additions & 3 deletions Bitkit.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 0 additions & 11 deletions Bitkit/AppScene.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,6 @@ struct AppScene: View {
.onChange(of: currency.hasStaleData, perform: handleCurrencyStaleData)
.onChange(of: wallet.walletExists, perform: handleWalletExistsChange)
.onChange(of: wallet.nodeLifecycleState, perform: handleNodeLifecycleChange)
.onChange(of: wallet.totalBalanceSats, perform: handleBalanceChange)
.onChange(of: scenePhase, perform: handleScenePhaseChange)
.environmentObject(app)
.environmentObject(navigation)
Expand Down Expand Up @@ -215,11 +214,6 @@ struct AppScene: View {
app?.handleLdkNodeEvent(lightningEvent)
}

wallet.addOnEvent(id: "activity-sync") { [weak activity] (_: Event) in
// TODO: this might not be the best for performace to sync all payments on every event. Could switch to habdling the specific event.
Task { try? await activity?.syncLdkNodePayments() }
}

if wallet.isRestoringWallet {
Task {
await BackupService.shared.performFullRestoreFromLatestBackup()
Expand Down Expand Up @@ -284,11 +278,6 @@ struct AppScene: View {
}
}

private func handleBalanceChange(_: Int) {
// Anytime we receive a balance update, we should sync the payments to activity list
Task { try? await activity.syncLdkNodePayments() }
}

private func handleScenePhaseChange(_: ScenePhase) {
// If PIN is enabled, lock the app when the app goes to the background
if scenePhase == .background && settings.pinEnabled {
Expand Down
Loading
Loading