feat: Transfer activities #212
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements transaction metadata storage for tracking transfer-related information that isn't provided by LDK's payment APIs. The main purpose is to temporarily store metadata (like whether a payment is a transfer) until it can be applied to activities during sync operations.
Key changes:
- Added
TransactionMetadataStorageservice using UserDefaults for persistence - Enhanced transaction sending and channel operations to capture and store metadata
- Implemented force channel close functionality with UI sheet
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| Bitkit/Models/TransactionMetadata.swift | New model for storing temporary transaction metadata including transfer flags and channel info |
| Bitkit/Services/TransactionMetadataStorage.swift | Storage service for persisting transaction metadata with CRUD operations |
| Bitkit/Services/LightningService.swift | Updated send and closeChannel methods to capture metadata and support force closes |
| Bitkit/Services/CoreService.swift | Added updateActivitiesMetadata to sync stored metadata with activities |
| Bitkit/ViewModels/WalletViewModel.swift | Added isTransfer parameter to send method |
| Bitkit/ViewModels/TransferViewModel.swift | Added force close functionality and SheetViewModel dependency |
| Bitkit/ViewModels/SheetViewModel.swift | Added forceTransfer sheet item |
| Bitkit/Views/Sheets/ForceTransferSheet.swift | New sheet for force channel close confirmation |
| Bitkit/MainNavView.swift | Registered ForceTransferSheet |
| Bitkit/AppScene.swift | Updated TransferViewModel initialization with SheetViewModel |
Member
Author
|
It will be replaced by #219 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the saving of transactions metadata. It is used to update the activities with info that is not provided by LDK payment class, like if a payments is a transfer
Linked Issues/Tasks
Roadmap - Activity overview
Screenshot / Video
transfer.mp4
restore.mp4