Skip to content

Conversation

@ben-kaufman
Copy link
Contributor

@ben-kaufman ben-kaufman commented Nov 3, 2025

This PR adds boosted txids tracking and displayed parent txids in the activity details.

Changes

  • Added boostTxIds: [String] field to OnchainActivity to store parent transaction IDs
  • CPFP: Append child transaction ID to parent's boostTxIds when boosting
  • RBF: Changed replacementTransactions to [String: [String]] to track parent txIds. Store parent txIds when creating replacement, retrieve and save when replacement syncs
  • UI: Display boosted transaction IDs in ActivityExplorerView with labels "BOOSTED TRANSACTION {num} (CPFP)" or "BOOSTED TRANSACTION {num} (RBF)" based on transaction direction

Note: This PR updates the bitkit-core version, which has an incompatible change in the sqlite DB, meaning existing apps will need to be uninstalled before updating to this version.

CPFP:
image

RBF:
image

@ben-kaufman ben-kaufman requested a review from jvsena42 November 3, 2025 17:23
@jvsena42
Copy link
Member

jvsena42 commented Nov 3, 2025

It would be nice to add a screenshot/preview of the feature

@jvsena42 jvsena42 requested a review from Copilot November 3, 2025 17:25
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements tracking and display of boosted transaction IDs in activity details. It extends the data model to store parent transaction IDs and shows them in the UI with appropriate labels.

  • Adds boostTxIds field to track parent transaction IDs in onchain activities
  • Implements different boosting strategies for CPFP and RBF transactions with proper parent tracking
  • Updates UI to display boosted transaction information with context-appropriate labels

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
BoostSheet.swift Adds boostTxIds initialization in activity creation
ActivityItemView.swift Adds boostTxIds field to preview data
ActivityExplorerView.swift Implements UI display of boosted transaction IDs with CPFP/RBF labels
CoreService.swift Core logic changes for tracking parent transactions in both CPFP and RBF scenarios
Package.resolved Updates bitkit-core dependency to support new boostTxIds field

@ovitrif
Copy link
Collaborator

ovitrif commented Nov 3, 2025

@ben-kaufman I think you'll need to setup PGP and configure your local git to use it, so your commits are signed 🙈

It's a requirement on the repo:

Google Chrome 2025-11-03 001010

You can probably squash locally + force push once that's applied locally on your machine

@ovitrif ovitrif enabled auto-merge November 3, 2025 19:39
@ben-kaufman ben-kaufman force-pushed the feat/show-boost-txids branch from 9754ccc to 1272242 Compare November 3, 2025 20:03
@ovitrif ovitrif merged commit 6f37c98 into master Nov 3, 2025
3 of 4 checks passed
@ben-kaufman ben-kaufman deleted the feat/show-boost-txids branch November 3, 2025 20:04
BitcoinErrorLog pushed a commit to BitcoinErrorLog/bitkit-ios that referenced this pull request Dec 15, 2025
Show boosted txids in Activity details of boosted transactions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants