Replace CurrencyService direct access #201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # app/src/main/java/to/bitkit/viewmodels/AppViewModel.kt
ovitrif
reviewed
Jun 19, 2025
auto-merge was automatically disabled
June 20, 2025 09:48
Pull request was converted to draft
ovitrif
approved these changes
Jun 20, 2025
Collaborator
ovitrif
left a comment
ovitrif
left a comment
There was a problem hiding this comment.
So much more confidence approving this PR even though it changes parts that are used everywhere throughout the app, all because of the critical unit tests for the conversion logic.
Thanks a lot for those and this refactor 🙇🏻
merging 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cachedRates: List<FxRate> variable from CurrencyService to follow a single source of trueContinuation of #199